All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerry Van Baren <gerald.vanbaren@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] intended behavior of bootm
Date: Mon, 21 Apr 2008 11:16:37 -0400	[thread overview]
Message-ID: <480CAFD5.7070804@ge.com> (raw)
In-Reply-To: <200804211658.26095.matthias.fuchs@esd-electronics.com>

Matthias Fuchs wrote:
> Hi,
> 
> after going through the boom code I found out, that
> setting the 'autostart' variable to 'no' brings me a little closer
> to what I want. But finally I end up
> in the enable_interrupts() at the very end of do_bootm(). This freezes
> my system. The reason for this is the Linux kernel image that is loaded to address 0
> and that overwrites the vector table. So reenabling the interrupts in U-Boot with
> Linux interrupt table is a bad idea.

No, having your (u-boot) interrupt go off while booting linux is a bad idea.

Which interrupt is going off?  Why is it going off (why isn't the 
hardware put into a quiescent state)?

> So what's the best idea to fix this? I could copy the vector table onto the stack
> in do_bootm() and copy it back just before reenabling the interrupts.

NO NO NO.

> Any better idea?
> 
> Matthias

That a u-boot initialized interrupt is occurring is wrong and needs to 
be fixed.
* Traditionally, u-boot does not use interrupts for anything, thus this 
isn't a problem.

* Proper hardware and device driver convention is that the hardware must 
be quiescent when linux is started and the linux device driver must 
(re)configure that hardware the way it wants/needs.  Obviously, this is 
probably a 95% rule (console I/O, memory initialization, some others may 
violate this rule for practical reasons).

* If your u-boot enables interrupt(s), you MUST disable the interrupt 
source before starting linux.  There is NO graceful way of getting linux 
to handle an interrupt that was a result of u-boot's running.  Starting 
linux with interrupts disabled is not a good solution - you may get 
lucky but leaving an active interrupt source is a dangerous game.  At 
best, it is a race condition that you may happen to win today.

Best regards,
gvb

  reply	other threads:[~2008-04-21 15:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-21 13:09 [U-Boot-Users] intended behavior of bootm Matthias Fuchs
2008-04-21 14:58 ` Matthias Fuchs
2008-04-21 15:16   ` Jerry Van Baren [this message]
2008-04-21 15:43     ` Matthias Fuchs
2008-04-21 16:28       ` Jerry Van Baren
2008-04-21 19:19 ` Wolfgang Denk
2008-04-21 21:02   ` Matthias Fuchs
2008-04-22 20:49     ` Wolfgang Denk
2008-04-23  8:43       ` Matthias Fuchs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=480CAFD5.7070804@ge.com \
    --to=gerald.vanbaren@ge.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.