All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: linux-pci@atrey.karlin.mff.cuni.cz,
	Jean Delvare <jdelvare@suse.de>,
	LKML <linux-kernel@vger.kernel.org>, Pavel Machek <pavel@ucw.cz>,
	Tejun Heo <htejun@gmail.com>,
	Tom Long Nguyen <tom.l.nguyen@intel.com>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Jeff Garzik <jgarzik@pobox.com>
Subject: Re: PCI MSI breaks when booting with nosmp
Date: Mon, 21 Apr 2008 21:41:25 +0200	[thread overview]
Message-ID: <480CEDE5.3060008@firstfloor.org> (raw)
In-Reply-To: <200804211207.00961.jbarnes@virtuousgeek.org>

Jesse Barnes wrote:
> On Monday, April 21, 2008 11:45 am Andi Kleen wrote:
>> Jesse Barnes <jbarnes@virtuousgeek.org> writes:
>>> Ok, I see this too on my desktop machine.  It looks like we're not
>>> getting interrupts setup correctly in the nosmp case.  Still digging
>>> through to see why though...
>> NoSMP disables the io-apic and a lot of modern systems don't work without
>> APIC.
>>
>> If you just want to run with a single cpu for testing etc. always use
>> maxcpus=1 (not 0, that will disable the APIC too)
> 
> Right...  but it looks like the MSI code is buggy when noapic is specified via 
> nosmp or maxcpus=0.  We should either fix it to work with noapic or disable 
> it like we do the ioapic when nosmp or maxcpus=0:

First that would likely not compile on architectures without PCI?

Also there is more code in the guts of arch/x86 that disables the
IO-APIC and likely has the same problem. Best probably you put it all
into a single function that does it all properly instead of continuning
to open code it.

Just don't break the other architectures in main.c

-Andi

  parent reply	other threads:[~2008-04-21 19:41 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-17 19:40 PCI MSI breaks when booting with nosmp Jean Delvare
2008-04-17 20:08 ` Jesse Barnes
2008-04-17 20:25   ` Jean Delvare
2008-04-21 17:43     ` Jesse Barnes
2008-04-21 18:45       ` Andi Kleen
2008-04-21 19:06         ` Jesse Barnes
2008-04-21 19:35           ` Jesse Barnes
2008-04-21 19:41           ` Andi Kleen [this message]
2008-04-21 19:43         ` Pavel Machek
2008-04-21 19:44           ` Andi Kleen
2008-04-22 21:25             ` Pavel Machek
2008-04-22 23:07               ` Jesse Barnes
2008-04-21 20:20         ` Jean Delvare
2008-04-21 20:40           ` Jesse Barnes
2008-04-21 20:46           ` Andi Kleen
2008-04-21 20:48             ` Jean Delvare
2008-04-21 21:09               ` Andi Kleen
2008-04-21 21:14                 ` Jesse Barnes
2008-04-22 13:27                   ` Jean Delvare
2008-04-22 15:50                     ` Jesse Barnes
2008-04-23 14:38                   ` Jean Delvare
2008-04-23 15:12                     ` Jesse Barnes
2008-04-23 18:13                       ` Maciej W. Rozycki
2008-04-23 18:23                         ` Jesse Barnes
2008-04-23 18:32                           ` Jesse Barnes
2008-04-23 18:32                           ` Jean Delvare
2008-04-23 18:38                           ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=480CEDE5.3060008@firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=htejun@gmail.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=jdelvare@suse.de \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=pavel@ucw.cz \
    --cc=rdunlap@xenotime.net \
    --cc=tom.l.nguyen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.