From: Jason Wessel <jason.wessel@windriver.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kgdb: fix signedness mixmatches, add statics, add declaration to header
Date: Mon, 21 Apr 2008 15:24:00 -0500 [thread overview]
Message-ID: <480CF7E0.8060906@windriver.com> (raw)
In-Reply-To: <1208544691.17196.48.camel@brick>
Harvey Harrison wrote:
> Noticed by sparse:
> arch/x86/kernel/kgdb.c:556:15: warning: symbol 'kgdb_arch_pc' was not declared. Should it be static?
> kernel/kgdb.c:149:8: warning: symbol 'kgdb_do_roundup' was not declared. Should it be static?
> kernel/kgdb.c:193:22: warning: symbol 'kgdb_arch_pc' was not declared. Should it be static?
> kernel/kgdb.c:712:5: warning: symbol 'remove_all_break' was not declared. Should it be static?
>
> Related to kgdb_hex2long:
> arch/x86/kernel/kgdb.c:371:28: warning: incorrect type in argument 2 (different signedness)
> arch/x86/kernel/kgdb.c:371:28: expected long *long_val
> arch/x86/kernel/kgdb.c:371:28: got unsigned long *<noident>
> kernel/kgdb.c:469:27: warning: incorrect type in argument 2 (different signedness)
> kernel/kgdb.c:469:27: expected long *long_val
> kernel/kgdb.c:469:27: got unsigned long *<noident>
> kernel/kgdb.c:470:27: warning: incorrect type in argument 2 (different signedness)
> kernel/kgdb.c:470:27: expected long *long_val
> kernel/kgdb.c:470:27: got unsigned long *<noident>
> kernel/kgdb.c:894:27: warning: incorrect type in argument 2 (different signedness)
> kernel/kgdb.c:894:27: expected long *long_val
> kernel/kgdb.c:894:27: got unsigned long *<noident>
> kernel/kgdb.c:895:27: warning: incorrect type in argument 2 (different signedness)
> kernel/kgdb.c:895:27: expected long *long_val
> kernel/kgdb.c:895:27: got unsigned long *<noident>
> kernel/kgdb.c:1127:28: warning: incorrect type in argument 2 (different signedness)
> kernel/kgdb.c:1127:28: expected long *long_val
> kernel/kgdb.c:1127:28: got unsigned long *<noident>
> kernel/kgdb.c:1132:25: warning: incorrect type in argument 2 (different signedness)
> kernel/kgdb.c:1132:25: expected long *long_val
> kernel/kgdb.c:1132:25: got unsigned long *<noident>
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
>
This patch looked fine Harvey, I queued it for the next pull request at:
http://git.kernel.org/?p=linux/kernel/git/jwessel/linux-2.6-kgdb.git;a=shortlog;h=for_linus
Jason.
prev parent reply other threads:[~2008-04-21 20:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-18 18:51 [PATCH] kgdb: fix signedness mixmatches, add statics, add declaration to header Harvey Harrison
2008-04-21 20:24 ` Jason Wessel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480CF7E0.8060906@windriver.com \
--to=jason.wessel@windriver.com \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.