All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Jeff Garzik <jeff@garzik.org>, Adrian Bunk <bunk@kernel.org>,
	linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [2.6 patch] select ATA_SFF
Date: Tue, 22 Apr 2008 22:24:05 +0900	[thread overview]
Message-ID: <480DE6F5.8060403@gmail.com> (raw)
In-Reply-To: <480DE3C4.5@ru.mvista.com>

Hi,

Sergei Shtylyov wrote:
>    ADMA is not SFF-8038i compilant, it's the IDE DMA spec of its own. 
> And I'm seeing references to libata-sff.c... confusing.

In libata, SFF is used for controllers which have TF interface and BMDMA 
is used for the BMDMA part of SFF-8038i.  I think this is the source of 
confusion here.

>    Looks like there's no clean separation within libata-sff.c itself 
> between SFF-8038i (BMDMA spec) and IDE registers itself -- that confused 
> me: at first I thought there's a big issue with a patch. :-/
> 
>    Jeff, Tejun, what "sff" in the file name actually means? Isn't it 
> strange that the drivers lacking DMA support or not really compliant 
> with SFF-8038i have to link with this file?

Maybe it should be libata-tf and libata-bmdma, but sff (sans bmdma) and 
bmdma is acceptable, hopefully, right?

Thanks.

-- 
tejun

  reply	other threads:[~2008-04-22 13:24 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-21 21:31 [2.6 patch] select ATA_SFF Adrian Bunk
2008-04-22 11:39 ` Jens Axboe
2008-04-22 13:10 ` Sergei Shtylyov
2008-04-22 13:24   ` Tejun Heo [this message]
2008-04-22 13:36     ` Sergei Shtylyov
2008-04-22 13:41       ` Tejun Heo
2008-04-22 14:35         ` Mark Lord
2008-04-22 14:38           ` Tejun Heo
2008-04-22 14:44             ` Mark Lord
2008-04-22 15:00               ` Tejun Heo
2008-04-22 15:04               ` Sergei Shtylyov
2008-04-22 18:54                 ` Sergei Shtylyov
2008-04-23  2:16                   ` Tejun Heo
2008-04-23  4:21                     ` Jeff Garzik
2008-04-23 11:16                       ` Sergei Shtylyov
2008-04-23 13:30                       ` Mark Lord
2008-04-22 14:43           ` Sergei Shtylyov
2008-04-22 14:51             ` Mark Lord
2008-04-24 11:35         ` Alan Cox
2008-04-24 12:45           ` Sergei Shtylyov
2008-04-24 12:50             ` Mark Lord
2008-04-24 13:00               ` Sergei Shtylyov
2008-04-24 14:27             ` Alan Cox
2008-04-24 15:30               ` Sergei Shtylyov
2008-04-24 15:15                 ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=480DE6F5.8060403@gmail.com \
    --to=htejun@gmail.com \
    --cc=bunk@kernel.org \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sshtylyov@ru.mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.