From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kevin Wolf <kwolf@suse.de>
Subject: [PATCH] xend: Create /var/run/tap during device model
	setup
Date: Wed, 23 Apr 2008 15:41:52 +0200
Message-ID: <480F3CA0.8090609@suse.de>
References: <C434E7B2.17BFC%keir.fraser@eu.citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="------------040808000204010406020509"
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C434E7B2.17BFC%keir.fraser@eu.citrix.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: "Li, Haicheng" <haicheng.li@intel.com>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

This is a multi-part message in MIME format.
--------------040808000204010406020509
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Keir Fraser schrieb:
> On 23/4/08 10:59, "Li, Haicheng" <haicheng.li@intel.com> wrote:
> 
>> 1. Fail to create any HVM guest on IA32PAE host
>> http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=1221
> 
> Looks like it is due to Kevin Wolf's changeset 17499. Your attempt to go
> back to older tools obviously didn't work -- the backtrace in xend.log comes
> from a line introduced by c/s 17499.

Create the directory /var/run/tap if it doesn't exist yet. Try to
continue even if the blktap communication pipes couldn't be created. The
VM might not need tap:ioemu and run just fine.

Signed-off-by: Kevin Wolf <kwolf@suse.de>

--------------040808000204010406020509
Content-Type: text/x-patch;
 name="make-blktap-path.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="make-blktap-path.patch"

diff -r 1d218f8898c9 tools/python/xen/xend/image.py
--- a/tools/python/xen/xend/image.py	Wed Apr 23 13:50:40 2008
+++ b/tools/python/xen/xend/image.py	Wed Apr 23 16:25:42 2008
@@ -205,9 +205,21 @@
         # If we use a device model, the pipes for communication between
         # blktapctrl and ioemu must be present before the devices are 
         # created (blktapctrl must access them for new block devices)
-        os.mkfifo('/var/run/tap/qemu-read-%d' % domid, 0600)
-        os.mkfifo('/var/run/tap/qemu-write-%d' % domid, 0600)
-        
+
+        # mkdir throws an exception if the path already exists
+        try:
+            os.mkdir('/var/run/tap', 0755)
+        except:
+            pass
+
+        try:
+            os.mkfifo('/var/run/tap/qemu-read-%d' % domid, 0600)
+            os.mkfifo('/var/run/tap/qemu-write-%d' % domid, 0600)
+        except OSError, e:
+            log.warn('Could not create blktap pipes for domain %d' % domid)
+            log.exception(e)
+            pass
+
 
     # Return a list of cmd line args to the device models based on the
     # xm config file

--------------040808000204010406020509
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--------------040808000204010406020509--