From: Boaz Harrosh <bharrosh@panasas.com>
To: Jens Axboe <jens.axboe@oracle.com>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
Pete Wyckoff <pw@osc.edu>,
linux-scsi <linux-scsi@vger.kernel.org>,
Linux-ide <linux-ide@vger.kernel.org>
Subject: [PATCH 5/5] block: add large command support
Date: Wed, 23 Apr 2008 18:13:04 +0300 [thread overview]
Message-ID: <480F5200.3040003@panasas.com> (raw)
In-Reply-To: <480F4CC2.7070804@panasas.com>
From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
This patch changes rq->cmd from the static array to a pointer to
support large commands.
We rarely handle large commands. So for optimization, a struct request
still has a static array for a command. blk_init_rq sets rq->cmd pointer
to the static array.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
---
block/blk-core.c | 1 +
include/linux/blkdev.h | 12 ++++++++++--
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index ca103d1..4c97fe2 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -119,6 +119,7 @@ void blk_init_rq(struct request_queue *q, struct request *rq, int cmd_flags)
RB_CLEAR_NODE(&rq->rb_node);
rq->tag = -1;
rq->ref_count = 1;
+ rq->cmd = rq->__cmd;
}
EXPORT_SYMBOL(blk_init_rq);
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 7121783..32ae32b 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -215,8 +215,9 @@ struct request {
/*
* when request is used as a packet command carrier
*/
- unsigned int cmd_len;
- unsigned char cmd[BLK_MAX_CDB];
+ unsigned short cmd_len;
+ unsigned char __cmd[BLK_MAX_CDB];
+ unsigned char *cmd;
unsigned int data_len;
unsigned int extra_len; /* length of alignment and padding */
@@ -818,6 +819,13 @@ static inline void put_dev_sector(Sector p)
page_cache_release(p.v);
}
+static inline void rq_set_cmd(struct request *rq, unsigned char *cmd,
+ unsigned short cmd_len)
+{
+ rq->cmd = cmd;
+ rq->cmd_len = cmd_len;
+}
+
struct work_struct;
int kblockd_schedule_work(struct work_struct *work);
void kblockd_flush_work(struct work_struct *work);
--
1.5.3.3
next prev parent reply other threads:[~2008-04-23 15:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 14:50 [RFC 0/5] block large commands support continue Boaz Harrosh
2008-04-23 14:57 ` [PATCH 1/5] block: no need to initialize rq->cmd Boaz Harrosh
2008-04-23 15:28 ` Boaz Harrosh
2008-04-23 15:01 ` [PATCH 2/5] block: replace sizeof(rq->cmd) with BLK_MAX_CDB Boaz Harrosh
2008-04-23 15:05 ` [RFC PATCH 3/5] block: Export rq_init, rename to blk_init_rq Boaz Harrosh
2008-04-23 15:09 ` [RFC PATCH 4/5] block: Use new blk_init_rq Boaz Harrosh
2008-04-23 15:13 ` Boaz Harrosh [this message]
2008-04-24 4:31 ` [RFC 0/5] block large commands support continue FUJITA Tomonori
2008-04-24 6:19 ` FUJITA Tomonori
2008-04-24 10:49 ` Jens Axboe
2008-04-24 15:17 ` FUJITA Tomonori
2008-04-25 9:22 ` Jens Axboe
2008-04-25 9:27 ` FUJITA Tomonori
2008-04-25 9:31 ` Jens Axboe
2008-04-25 10:03 ` FUJITA Tomonori
2008-04-25 10:25 ` Jens Axboe
2008-04-25 10:29 ` FUJITA Tomonori
2008-04-27 8:26 ` Boaz Harrosh
2008-04-27 8:42 ` FUJITA Tomonori
2008-04-27 8:42 ` FUJITA Tomonori
2008-04-27 9:06 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480F5200.3040003@panasas.com \
--to=bharrosh@panasas.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bzolnier@gmail.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=jens.axboe@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pw@osc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.