All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roel Kluin <12o3l@tiscali.nl>
To: paulus@samba.org, linuxppc-dev@ozlabs.org
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/2] powerpc: mpic_pasemi_msi: failed allocation unnoticed
Date: Wed, 23 Apr 2008 18:54:33 +0200	[thread overview]
Message-ID: <480F69C9.4040208@tiscali.nl> (raw)
In-Reply-To: <480F6905.3070808@tiscali.nl>

A similar problem in arch/powerpc/sysdev/mpic_u3msi.c:
---
bitmap_find_free_region(), called by mpic_msi_alloc_hwirqs() may
return -ENOMEM, but hwirq of type irq_hw_number_t which is unsigned.

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
The functions can be found respectively in:
//---[ vi lib/bitmap.c +807 ]---
//---[ vi arch/powerpc/sysdev/mpic_msi.c +39 ]---

diff --git a/arch/powerpc/sysdev/mpic_u3msi.c b/arch/powerpc/sysdev/mpic_u3msi.c
index 1d5a408..30a4e27 100644
--- a/arch/powerpc/sysdev/mpic_u3msi.c
+++ b/arch/powerpc/sysdev/mpic_u3msi.c
@@ -122,7 +122,7 @@ static int u3msi_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type)
 
 	list_for_each_entry(entry, &pdev->msi_list, list) {
 		hwirq = mpic_msi_alloc_hwirqs(msi_mpic, 1);
-		if (hwirq < 0) {
+		if (hwirq == -ENOMEM) {
 			pr_debug("u3msi: failed allocating hwirq\n");
 			return hwirq;
 		}

  reply	other threads:[~2008-04-23 16:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-23 16:51 [PATCH] powerpc: mpic_pasemi_msi: failed allocation unnoticed Roel Kluin
2008-04-23 16:54 ` Roel Kluin [this message]
2008-04-23 19:00 ` [PATCH 2/2] mpic_u3msi: mpic_u3msi: " Roel Kluin
2008-04-23 22:09   ` Segher Boessenkool
2008-04-23 22:09     ` Segher Boessenkool
2008-04-23 22:25     ` [PATCH 2/2 v2] " Roel Kluin
2008-04-23 22:25       ` Roel Kluin
2008-04-23 23:03       ` Roel Kluin
2008-04-23 23:03         ` Roel Kluin
2008-04-23 23:36       ` Michael Ellerman
2008-04-23 23:36         ` Michael Ellerman
2008-04-24  0:42         ` Benjamin Herrenschmidt
2008-04-24  0:42           ` Benjamin Herrenschmidt
2008-04-23 22:32 ` [PATCH 1/2 v2] powerpc: mpic_pasemi_msi: " Roel Kluin
2008-04-23 22:32   ` Roel Kluin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=480F69C9.4040208@tiscali.nl \
    --to=12o3l@tiscali.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.