From: Roel Kluin <12o3l@tiscali.nl>
To: galak@kernel.crashing.org, linuxppc-dev@ozlabs.org
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH] spi_mpc83xx: test below 0 on unsigned irq in mpc83xx_spi_probe()
Date: Wed, 23 Apr 2008 22:19:33 +0200 [thread overview]
Message-ID: <480F99D5.7070300@tiscali.nl> (raw)
mpc83xx_spi->irq is unsigned, so the test fails
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/spi/spi_mpc83xx.c b/drivers/spi/spi_mpc83xx.c
index be15a62..033fd51 100644
--- a/drivers/spi/spi_mpc83xx.c
+++ b/drivers/spi/spi_mpc83xx.c
@@ -454,12 +454,12 @@ static int __init mpc83xx_spi_probe(struct platform_device *dev)
goto put_master;
}
- mpc83xx_spi->irq = platform_get_irq(dev, 0);
-
- if (mpc83xx_spi->irq < 0) {
- ret = -ENXIO;
+ ret = platform_get_irq(dev, 0);
+ if (ret < 0)
goto unmap_io;
- }
+
+ mpc83xx_spi->irq = ret;
+ ret = 0;
/* Register for SPI Interrupt */
ret = request_irq(mpc83xx_spi->irq, mpc83xx_spi_irq,
next reply other threads:[~2008-04-23 20:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 20:19 Roel Kluin [this message]
[not found] ` <480F99D5.7070300-IWqWACnzNjzz+pZb47iToQ@public.gmane.org>
2008-04-23 20:39 ` [PATCH] spi_mpc83xx: test below 0 on unsigned irq in mpc83xx_spi_probe() Kumar Gala
2008-04-23 20:39 ` Kumar Gala
2008-04-30 22:12 ` [spi-devel-general] " David Brownell
2008-04-30 22:12 ` David Brownell
2008-04-23 20:55 ` [PATCH 2/2] xilinx_spi: test below 0 on unsigned irq in xilinx_spi_probe() Roel Kluin
2008-04-23 20:55 ` Roel Kluin
[not found] ` <480FA248.7080900-IWqWACnzNjzz+pZb47iToQ@public.gmane.org>
2008-04-24 7:35 ` [PATCH 2/2 v2] " Roel Kluin
2008-04-24 7:35 ` Roel Kluin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480F99D5.7070300@tiscali.nl \
--to=12o3l@tiscali.nl \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.