From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roel Kluin <12o3l-IWqWACnzNjzz+pZb47iToQ@public.gmane.org> Subject: [PATCH 2/2] xilinx_spi: test below 0 on unsigned irq in xilinx_spi_probe() Date: Wed, 23 Apr 2008 22:55:36 +0200 Message-ID: <480FA248.7080900@tiscali.nl> References: <480F99D5.7070300@tiscali.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: lkml To: dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Return-path: In-Reply-To: <480F99D5.7070300-IWqWACnzNjzz+pZb47iToQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org similarly, --- xilinx_spi->irq is unsigned, so the test fails Signed-off-by: Roel Kluin <12o3l-IWqWACnzNjzz+pZb47iToQ@public.gmane.org> --- diff --git a/drivers/spi/xilinx_spi.c b/drivers/spi/xilinx_spi.c index cf6aef3..613db82 100644 --- a/drivers/spi/xilinx_spi.c +++ b/drivers/spi/xilinx_spi.c @@ -353,11 +353,12 @@ static int __init xilinx_spi_probe(struct platform_device *dev) goto put_master; } - xspi->irq = platform_get_irq(dev, 0); - if (xspi->irq < 0) { - ret = -ENXIO; + ret = platform_get_irq(dev, 0); + if (ret < 0) goto unmap_io; - } + + xspi->irq = ret; + ret = 0; master->bus_num = pdata->bus_num; master->num_chipselect = pdata->num_chipselect; ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757598AbYDWUzt (ORCPT ); Wed, 23 Apr 2008 16:55:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756605AbYDWUzk (ORCPT ); Wed, 23 Apr 2008 16:55:40 -0400 Received: from smtp-out0.tiscali.nl ([195.241.79.175]:44861 "EHLO smtp-out0.tiscali.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753247AbYDWUzj (ORCPT ); Wed, 23 Apr 2008 16:55:39 -0400 Message-ID: <480FA248.7080900@tiscali.nl> Date: Wed, 23 Apr 2008 22:55:36 +0200 From: Roel Kluin <12o3l@tiscali.nl> User-Agent: Thunderbird 2.0.0.9 (X11/20071031) MIME-Version: 1.0 To: dbrownell@users.sourceforge.net, spi-devel-general@lists.sourceforge.net CC: lkml Subject: [PATCH 2/2] xilinx_spi: test below 0 on unsigned irq in xilinx_spi_probe() References: <480F99D5.7070300@tiscali.nl> In-Reply-To: <480F99D5.7070300@tiscali.nl> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org similarly, --- xilinx_spi->irq is unsigned, so the test fails Signed-off-by: Roel Kluin <12o3l@tiscali.nl> --- diff --git a/drivers/spi/xilinx_spi.c b/drivers/spi/xilinx_spi.c index cf6aef3..613db82 100644 --- a/drivers/spi/xilinx_spi.c +++ b/drivers/spi/xilinx_spi.c @@ -353,11 +353,12 @@ static int __init xilinx_spi_probe(struct platform_device *dev) goto put_master; } - xspi->irq = platform_get_irq(dev, 0); - if (xspi->irq < 0) { - ret = -ENXIO; + ret = platform_get_irq(dev, 0); + if (ret < 0) goto unmap_io; - } + + xspi->irq = ret; + ret = 0; master->bus_num = pdata->bus_num; master->num_chipselect = pdata->num_chipselect;