From: Roel Kluin <12o3l@tiscali.nl>
To: hnguyen@de.ibm.com, raisch@de.ibm.com
Cc: general@lists.openfabrics.org, lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH] ehca: ret is unsigned, ibmebus_request_irq() negative return ignored in hca_create_eq()
Date: Wed, 23 Apr 2008 23:07:53 +0200 [thread overview]
Message-ID: <480FA529.2030800@tiscali.nl> (raw)
diff --git a/drivers/infiniband/hw/ehca/ehca_eq.c b/drivers/infiniband/hw/ehca/ehca_eq.c
index b4ac617..9727235 100644
--- a/drivers/infiniband/hw/ehca/ehca_eq.c
+++ b/drivers/infiniband/hw/ehca/ehca_eq.c
@@ -59,6 +59,7 @@ int ehca_create_eq(struct ehca_shca *shca,
u32 i;
void *vpage;
struct ib_device *ib_dev = &shca->ib_device;
+ int ret2;
spin_lock_init(&eq->spinlock);
spin_lock_init(&eq->irq_spinlock);
@@ -123,18 +124,18 @@ int ehca_create_eq(struct ehca_shca *shca,
/* register interrupt handlers and initialize work queues */
if (type == EHCA_EQ) {
- ret = ibmebus_request_irq(eq->ist, ehca_interrupt_eq,
+ ret2 = ibmebus_request_irq(eq->ist, ehca_interrupt_eq,
IRQF_DISABLED, "ehca_eq",
(void *)shca);
- if (ret < 0)
+ if (ret2 < 0)
ehca_err(ib_dev, "Can't map interrupt handler.");
tasklet_init(&eq->interrupt_task, ehca_tasklet_eq, (long)shca);
} else if (type == EHCA_NEQ) {
- ret = ibmebus_request_irq(eq->ist, ehca_interrupt_neq,
+ ret2 = ibmebus_request_irq(eq->ist, ehca_interrupt_neq,
IRQF_DISABLED, "ehca_neq",
(void *)shca);
- if (ret < 0)
+ if (ret2 < 0)
ehca_err(ib_dev, "Can't map interrupt handler.");
tasklet_init(&eq->interrupt_task, ehca_tasklet_neq, (long)shca);
next reply other threads:[~2008-04-23 21:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 21:07 Roel Kluin [this message]
2008-04-28 16:36 ` [PATCH] ehca: ret is unsigned, ibmebus_request_irq() negative return ignored in hca_create_eq() Hoang-Nam Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480FA529.2030800@tiscali.nl \
--to=12o3l@tiscali.nl \
--cc=general@lists.openfabrics.org \
--cc=hnguyen@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=raisch@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.