From: Roel Kluin <12o3l@tiscali.nl>
To: hjlipp@web.de, tilman@imap.cc
Cc: gigaset307x-common@lists.sourceforge.net,
lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH] gigaset: gigaset_isowbuf_getbytes() may return signed unnoticed
Date: Wed, 23 Apr 2008 23:27:24 +0200 [thread overview]
Message-ID: <480FA9BC.7070205@tiscali.nl> (raw)
ifd->offset is unsigned. gigaset_isowbuf_getbytes() may return signed unnoticed
Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/isdn/gigaset/bas-gigaset.c b/drivers/isdn/gigaset/bas-gigaset.c
index 5255b5e..c97479b 100644
--- a/drivers/isdn/gigaset/bas-gigaset.c
+++ b/drivers/isdn/gigaset/bas-gigaset.c
@@ -1050,9 +1050,9 @@ static int submit_iso_write_urb(struct isow_urbctx_t *ucx)
}
/* retrieve block of data to send */
- ifd->offset = gigaset_isowbuf_getbytes(ubc->isooutbuf,
- ifd->length);
- if (ifd->offset < 0) {
+ rc = gigaset_isowbuf_getbytes(ubc->isooutbuf, ifd->length);
+ ifd->offset = rc;
+ if (rc < 0) {
if (ifd->offset == -EBUSY) {
gig_dbg(DEBUG_ISO,
"%s: buffer busy at frame %d",
next reply other threads:[~2008-04-23 21:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 21:27 Roel Kluin [this message]
2008-04-25 9:29 ` [PATCH] gigaset: gigaset_isowbuf_getbytes() may return signed unnoticed Tilman Schmidt
-- strict thread matches above, loose matches on Subject: below --
2008-05-10 17:52 Tilman Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480FA9BC.7070205@tiscali.nl \
--to=12o3l@tiscali.nl \
--cc=gigaset307x-common@lists.sourceforge.net \
--cc=hjlipp@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.