From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: denys@visp.net.lb, netdev@vger.kernel.org
Subject: Re: mutex WARNING while running ip from iproute2 package
Date: Thu, 24 Apr 2008 05:25:43 +0200 [thread overview]
Message-ID: <480FFDB7.8050706@trash.net> (raw)
In-Reply-To: <20080423.202050.255399231.davem@davemloft.net>
David Miller wrote:
> From: Patrick McHardy <kaber@trash.net>
> Date: Thu, 24 Apr 2008 05:12:14 +0200
>
>> Sure. This seems to be the bogus ASSERT_RTNL warning caused
>> by mutex_trylock() while holding a spinlock. The warning
>> itself is harmless, since we're already holding the RTNL,
>> mutex_trylock won't succeed.
>
> I'm sorry, I had forgotten about this. :-/
>
>> Herbert suggested to store address updates in atomic context
>> on a temporary list and do the actual update in process
>> context. This seems like a good idea to simplify the address
>> list locking, unfortunately I didn't manage to take care of
>> this yet. An alternative fix to silent the bogus warning would
>> be to use mutex_is_locked in ASSERT_RTNL, but Herbert didn't
>> like that idea.
>
> I think we need something like the latter in any event.
I'll cook up a patch for this.
prev parent reply other threads:[~2008-04-24 3:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-20 14:57 mutex WARNING while running ip from iproute2 package Denys Fedoryshchenko
2008-04-24 2:41 ` David Miller
2008-04-24 3:12 ` Patrick McHardy
2008-04-24 3:20 ` David Miller
2008-04-24 3:25 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480FFDB7.8050706@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=denys@visp.net.lb \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.