From: "Yang, Xiao/杨 晓" <yangx.jy@fujitsu.com>
To: "Darrick J. Wong" <djwong@kernel.org>,
<linux-xfs@vger.kernel.org>, <david@fromorbit.com>
Subject: Re: [RFC PATCH] xfs/179: modify test to trigger refcount update bugs
Date: Wed, 30 Nov 2022 18:07:14 +0800 [thread overview]
Message-ID: <480d7699-5971-9125-0669-a4e77b641c5b@fujitsu.com> (raw)
In-Reply-To: <Y4aCb+y2ej1TBE/R@magnolia>
On 2022/11/30 6:06, Darrick J. Wong wrote:
> From: Darrick J. Wong<djwong@kernel.org>
>
> Upon enabling fsdax + reflink for XFS, this test began to report
> refcount metadata corruptions after being run. Specifically, xfs_repair
> noticed single-block refcount records that could be combined but had not
> been.
>
> The root cause of this is improper MAXREFCOUNT edge case handling in
> xfs_refcount_merge_extents. When we're trying to find candidates for a
> record merge, we compute the refcount of the merged record, but without
> accounting for the fact that once a record hits rc_refcount ==
> MAXREFCOUNT, it is pinned that way forever.
>
> Adjust this test to use a sub-filesize write for one of the COW writes,
> because this is how we force the extent merge code to run.
Hi Darrick,
Cool, it is reliable to reproduce the same issue in non-DAX mode.
Reviewed-by: Xiao Yang <yangx.jy@fujitsu.com>
Tested-by: Xiao Yang <yangx.jy@fujitsu.com>
Best Regards,
Xiao Yang
prev parent reply other threads:[~2022-11-30 10:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 22:01 [PATCHSET 0/2] xfs: fix broken MAXREFCOUNT handling Darrick J. Wong
2022-11-29 22:01 ` [PATCH 1/2] xfs: hoist refcount record merge predicates Darrick J. Wong
2022-11-29 22:35 ` Dave Chinner
2022-11-30 0:13 ` Darrick J. Wong
2022-11-30 9:24 ` Yang, Xiao/杨 晓
2022-11-29 22:01 ` [PATCH 2/2] xfs: estimate post-merge refcounts correctly Darrick J. Wong
2022-11-29 22:37 ` Dave Chinner
2022-11-30 9:32 ` Yang, Xiao/杨 晓
2022-11-30 18:49 ` Darrick J. Wong
2022-11-29 22:06 ` [RFC PATCH] xfs/179: modify test to trigger refcount update bugs Darrick J. Wong
2022-11-29 22:42 ` Dave Chinner
2022-11-30 0:19 ` Darrick J. Wong
2022-11-30 10:07 ` Yang, Xiao/杨 晓 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=480d7699-5971-9125-0669-a4e77b641c5b@fujitsu.com \
--to=yangx.jy@fujitsu.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.