From mboxrd@z Thu Jan 1 00:00:00 1970 From: NISHIGUCHI Naoki Subject: Re: [PATCH] Fix deadlock in schedule.c at TRACE mode Date: Thu, 24 Apr 2008 16:03:04 +0900 Message-ID: <481030A8.7080506@jp.fujitsu.com> References: <48100DF2.5000605@jp.fujitsu.com> <200804240542.m3O5gswi016365@fjmscan502.ms.jp.fujitsu.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------060703050006060509040508" Return-path: In-Reply-To: <200804240542.m3O5gswi016365@fjmscan502.ms.jp.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Atsushi SAKAI , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --------------060703050006060509040508 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Hi, Atsushi Atsushi SAKAI wrote: > I have two questions about this. > > 1)How to reproduce your deadlock ? > Would you give me your test environment to reproduce this deadlock? > Is it easily reproduced by running xenmon.py or xentrace > with one or two guest domain(s)? > 　or Any additional condition needed? This deadlock can be easily reproduced by running xenmon.py without guest domain. Furthermore, this deadlock occurs easier by applying my patch to xenbaked.c. Subject of my patch is "[PATCH] Fix access to trace buffer after xentrace changes". > 2)About fixing code, > I think __trace_var() should fix for this issue not schedule() > This issue cannot be fixed by modify the __trace_var()? Thanks for your advise. I agree with you. I fixed this deadlock using tasklet in trace.c. Here is the patch. Thanks, Naoki Nishiguchi --------------060703050006060509040508 Content-Type: text/plain; name="trace.patch" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="trace.patch" ZGlmZiAtciA3N2RlYzg3MzJjZGUgeGVuL2NvbW1vbi90cmFjZS5jCi0tLSBhL3hlbi9jb21t b24vdHJhY2UuYwlXZWQgQXByIDIzIDE2OjU4OjQ0IDIwMDggKzAxMDAKKysrIGIveGVuL2Nv bW1vbi90cmFjZS5jCVRodSBBcHIgMjQgMTU6NTY6MzcgMjAwOCArMDkwMApAQCAtNjksNiAr NjksMTMgQEAgc3RhdGljIGNwdW1hc2tfdCB0Yl9jcHVfbWFzayA9IENQVV9NQVNLXwogLyog d2hpY2ggdHJhY2luZyBldmVudHMgYXJlIGVuYWJsZWQgKi8KIHN0YXRpYyB1MzIgdGJfZXZl bnRfbWFzayA9IFRSQ19BTEw7CiAKK3N0YXRpYyB2b2lkIHRyYWNlX25vdGlmeV9ndWVzdCh1 bnNpZ25lZCBsb25nIHVudXNlZCkKK3sKKyAgICBzZW5kX2d1ZXN0X2dsb2JhbF92aXJxKGRv bTAsIFZJUlFfVEJVRik7Cit9CisKK3N0YXRpYyBERUNMQVJFX1RBU0tMRVQodHJhY2VfdGFz a2xldCwgdHJhY2Vfbm90aWZ5X2d1ZXN0LCAwKTsKKwogLyoqCiAgKiBhbGxvY190cmFjZV9i dWZzIC0gcGVyZm9ybXMgaW5pdGlhbGl6YXRpb24gb2YgdGhlIHBlci1jcHUgdHJhY2UgYnVm ZmVycy4KICAqCkBAIC01MDYsNyArNTEzLDcgQEAgdm9pZCBfX3RyYWNlX3Zhcih1MzIgZXZl bnQsIGludCBjeWNsZXMsIAogICAgIC8qIE5vdGlmeSB0cmFjZSBidWZmZXIgY29uc3VtZXIg dGhhdCB3ZSd2ZSBjcm9zc2VkIHRoZSBoaWdoIHdhdGVyIG1hcmsuICovCiAgICAgaWYgKCBz dGFydGVkX2JlbG93X2hpZ2h3YXRlciAmJgogICAgICAgICAgKGNhbGNfdW5jb25zdW1lZF9i eXRlcyhidWYpID49IHRfYnVmX2hpZ2h3YXRlcikgKQotICAgICAgICBzZW5kX2d1ZXN0X2ds b2JhbF92aXJxKGRvbTAsIFZJUlFfVEJVRik7CisgICAgICAgIHRhc2tsZXRfc2NoZWR1bGUo JnRyYWNlX3Rhc2tsZXQpOwogfQogCiAvKgo= --------------060703050006060509040508 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --------------060703050006060509040508--