From: Jeff Garzik <jeff@garzik.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
Rene Herman <rene.herman@keyaccess.nl>,
Adrian Bunk <bunk@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
rmk@arm.linux.org.uk, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [git patch] free_irq() fixes
Date: Thu, 24 Apr 2008 11:40:22 -0400 [thread overview]
Message-ID: <4810A9E6.1080201@garzik.org> (raw)
In-Reply-To: <alpine.LFD.1.10.0804240806500.2779@woody.linux-foundation.org>
Linus Torvalds wrote:
> The absolutely _only_ piece of reliably information we have that is
> architecture- and irq-controller neutral is the exact information we pass
> in to "request_irq()". That is: irq number, the name, and the device
> cookie thing. Nothing more.
Agreed.
However, it does not follow that an int is what _must_ be passed around.
We already have design patterns like
cookie_pointer = ioremap(raw bus resource)
Not that I am the one pushing for that, just noting.
Overall this is all wild-assed speculation based on a thought
exploration (#irq-remove) that a several kernel hackers seemed to like.
> - the "device cookie". This is the thing that the system itself doesn't
> care about, and is _entirely_ under control of the driver, so the
> driver can pass its own interrupt controller some helpful instance
> pointers.
>
> So of the three, "device cookie" is the one that we absolutely have to
> have. The irq number is not necessary, but it does actually have some
> meaning especially for legacy devices (eg ISA), and it is at least
> _sensible_ to pass around (ie it has no downsides, and it's not
> fundamentally broken). And the name would be just stupid.
Agreed.
> EVERYTHING else would be architecture-specific. And that is exactly what
> we do not want. EVER.
Not true -- you have metadata/OOB data like MSI messages, where you are
passed a value from the PCI hardware in the PCI message, not just an
"interrupt asserted" condition. Or s/value/values/ if you enable PCI
MSI's multiple message support.
The PCI devices themselves are moving from sending a single bit of
information ("irq!") to sending actual messages.
That is not arch-specific at all, but a new model for "interrupt" (i.e.
event) notification being pushed upon us.
Jeff
next prev parent reply other threads:[~2008-04-24 15:41 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 22:17 [git patch] free_irq() fixes Jeff Garzik
2008-04-22 22:25 ` Linus Torvalds
2008-04-22 22:59 ` Jeff Garzik
2008-04-22 23:20 ` Linus Torvalds
2008-04-22 23:49 ` Jeff Garzik
2008-04-22 23:52 ` Linus Torvalds
2008-04-23 0:05 ` Adrian Bunk
2008-04-23 0:16 ` Linus Torvalds
2008-04-23 13:51 ` Rene Herman
2008-04-24 2:10 ` Jeff Garzik
2008-04-24 2:19 ` Linus Torvalds
2008-04-24 5:59 ` Eric W. Biederman
2008-04-24 10:53 ` Jeff Garzik
2008-04-24 15:16 ` Linus Torvalds
2008-04-24 15:40 ` Jeff Garzik [this message]
2008-04-24 15:55 ` Linus Torvalds
2008-04-24 15:37 ` Alan Cox
2008-04-24 16:20 ` Jeff Garzik
2008-04-24 16:16 ` Jeff Garzik
2008-04-24 16:48 ` Eric W. Biederman
2008-04-24 16:58 ` Linus Torvalds
2008-04-24 18:15 ` Eric W. Biederman
2008-04-24 17:30 ` Jeff Garzik
2008-04-25 2:53 ` Eric W. Biederman
2008-04-25 3:33 ` MSI, fun for the whole family (was Re: [git patch] free_irq() fixes) Jeff Garzik
2008-04-25 3:57 ` MSI, fun for the whole family Roland Dreier
2008-04-25 4:19 ` David Miller
2008-04-25 4:35 ` Jeff Garzik
2008-04-25 5:48 ` Eric W. Biederman
2008-04-25 22:44 ` Roland Dreier
2008-04-25 5:08 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4810A9E6.1080201@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rene.herman@keyaccess.nl \
--cc=rmk@arm.linux.org.uk \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.