All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roel Kluin <12o3l@tiscali.nl>
To: Dan Williams <dcbw@redhat.com>
Cc: mcgrof@gmail.com, linux-wireless@vger.kernel.org,
	lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH v2] prism54: prism54_get_encode() test below 0 on unsigned index
Date: Fri, 25 Apr 2008 02:45:14 +0200	[thread overview]
Message-ID: <4811299A.7060407@tiscali.nl> (raw)
In-Reply-To: <1209056973.5224.0.camel@localhost.localdomain>

Dan Williams wrote:
> On Wed, 2008-04-23 at 21:56 +0200, Roel Kluin wrote:

>> u32 index = (dwrq->flags & IW_ENCODE_INDEX) - 1;
> 
> Probably should just change that to an 'int' instead of a u32.
> 
> Dan
> 

Thanks, in that case use the patch below
---
when left unsigned, the test 'if (index < 0)' will not work.

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
---
diff --git a/drivers/net/wireless/prism54/isl_ioctl.c b/drivers/net/wireless/prism54/isl_ioctl.c
index e5b3c28..8076ead 100644
--- a/drivers/net/wireless/prism54/isl_ioctl.c
+++ b/drivers/net/wireless/prism54/isl_ioctl.c
@@ -1158,7 +1158,8 @@ prism54_get_encode(struct net_device *ndev, struct iw_request_info *info,
 {
 	islpci_private *priv = netdev_priv(ndev);
 	struct obj_key *key;
-	u32 devindex, index = (dwrq->flags & IW_ENCODE_INDEX) - 1;
+	u32 devindex;
+	int index = (dwrq->flags & IW_ENCODE_INDEX) - 1;
 	u32 authen = 0, invoke = 0, exunencrypt = 0;
 	int rvalue;
 	union oid_res_t r;


  reply	other threads:[~2008-04-25  0:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-23 19:56 [PATCH] prism54: prism54_get_encode() test below 0 on unsigned index Roel Kluin
2008-04-24 17:09 ` Dan Williams
2008-04-25  0:45   ` Roel Kluin [this message]
2008-04-26  4:39     ` [PATCH v2] " Luis R. Rodriguez
2008-04-28  4:10       ` Dan Williams
  -- strict thread matches above, loose matches on Subject: below --
2008-04-27 12:25 Roger While
2008-04-27 19:48 ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4811299A.7060407@tiscali.nl \
    --to=12o3l@tiscali.nl \
    --cc=dcbw@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mcgrof@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.