From: Josh Triplett <josh@freedesktop.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: David Howells <dhowells@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-sparse@vger.kernel.org
Subject: Re: [PATCH 1/2] Fix cast instruction generation
Date: Thu, 24 Apr 2008 19:24:42 -0700 [thread overview]
Message-ID: <481140EA.9040803@freedesktop.org> (raw)
In-Reply-To: <alpine.LFD.1.10.0804241443460.2779@woody.linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 879 bytes --]
Linus Torvalds wrote:
> From: Linus Torvalds <torvalds@woody.linux-foundation.org>
> Date: Thu, 24 Apr 2008 14:45:43 -0700
>
> Whether it's a sign-extending cast or not depends on the source
> of the cast, not destination. The final size of the cast depends
> on the destination, of course.
>
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> ---
> In thread "[PATCH] RxRPC: Fix a regression in the RXKAD security module"
>
> On Thu, 24 Apr 2008, Linus Torvalds wrote:
>> Ok, that looks stupid, and should even have had a warning (shifting a u16
>> right by 16 should warn about it being pointless, but doesn't, because the
>> compiler quietly expands it to "int" in the meantime).
>>
>> Hmm. I could do something to sparse that warns about that too.
>
> Something along the lines of this?
Applied and pushed.
- Josh Triplett
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]
prev parent reply other threads:[~2008-04-25 2:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-24 19:38 [PATCH] RxRPC: Fix a regression in the RXKAD security module David Howells
2008-04-24 20:21 ` Al Viro
2008-04-24 20:45 ` Linus Torvalds
2008-04-24 21:52 ` [PATCH 1/2] Fix cast instruction generation Linus Torvalds
2008-04-24 21:54 ` [PATCH 2/2] Simplify (and warn about) right shifts that result in zero Linus Torvalds
2008-04-24 23:52 ` Pavel Roskin
2008-04-25 0:03 ` Linus Torvalds
2008-04-25 0:34 ` Pavel Roskin
2008-04-25 2:32 ` Josh Triplett
2008-04-25 2:29 ` Josh Triplett
2008-04-25 2:24 ` Josh Triplett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481140EA.9040803@freedesktop.org \
--to=josh@freedesktop.org \
--cc=dhowells@redhat.com \
--cc=linux-sparse@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.