From: Jeff Garzik <jeff@garzik.org>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] WAN: Fix confusing insmod error code for C101 too.
Date: Fri, 25 Apr 2008 02:02:04 -0400 [thread overview]
Message-ID: <481173DC.6010907@garzik.org> (raw)
In-Reply-To: <m3myno5u5b.fsf@maximus.localdomain>
Krzysztof Halasa wrote:
> WAN: Fix confusing insmod error code for C101 too.
>
> Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
>
> diff --git a/drivers/net/wan/c101.c b/drivers/net/wan/c101.c
> index c4c8eab..c2cc42f 100644
> --- a/drivers/net/wan/c101.c
> +++ b/drivers/net/wan/c101.c
> @@ -402,7 +402,7 @@ static int __init c101_init(void)
> #ifdef MODULE
> printk(KERN_INFO "c101: no card initialized\n");
> #endif
> - return -ENOSYS; /* no parameters specified, abort */
> + return -EINVAL; /* no parameters specified, abort */
> }
>
> printk(KERN_INFO "%s\n", version);
> @@ -420,11 +420,11 @@ static int __init c101_init(void)
> c101_run(irq, ram);
>
> if (*hw == '\x0')
> - return first_card ? 0 : -ENOSYS;
> + return first_card ? 0 : -EINVAL;
> }while(*hw++ == ':');
>
> printk(KERN_ERR "c101: invalid hardware parameters\n");
> - return first_card ? 0 : -ENOSYS;
> + return first_card ? 0 : -EINVAL;
> }
>
applied
prev parent reply other threads:[~2008-04-25 6:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-20 17:10 [PATCH] WAN: Fix confusing insmod error code for C101 too Krzysztof Halasa
2008-04-25 6:02 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481173DC.6010907@garzik.org \
--to=jeff@garzik.org \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.