From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Winchell <dwinchell@virtualiron.com>
Subject: Re: Re: Fix for get_s_time()
Date: Fri, 25 Apr 2008 15:48:02 -0400
Message-ID: <48123572.60106@virtualiron.com>
References: <C43675C0.1FEDC%keir.fraser@eu.citrix.com>
	<4810D247.7040400@virtualiron.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="------------090501030308050902050601"
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4810D247.7040400@virtualiron.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
Cc: "Tian, Kevin" <kevin.tian@intel.com>, Dave Winchell <dwinchell@virtualiron.com>, "dan.magenheimer@oracle.com" <dan.magenheimer@oracle.com>, Ian Pratt <Ian.Pratt@eu.citrix.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Keir Fraser <keir.fraser@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

This is a multi-part message in MIME format.
--------------090501030308050902050601
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Keir,

Last nights run had the error in the 12 ppm range.
Here is the change we have been talking about.

-Dave

Dave Winchell wrote:

> Keir Fraser wrote:
>
>> On 24/4/08 17:04, "Dave Winchell" <dwinchell@virtualiron.com> wrote:
>>
>>  
>>
>>> yes, this is the issue. What you suggest should be fine and I am trying
>>> it now.
>>> With the locking version (and a fix to a bug I introduced) I got .0012%
>>> error
>>> on an overnight run with hpet layered on get_s_time_mono(), which is 
>>> the
>>> max(prev, cur) layer on get_s_time we discussed.
>>>   
>>
>>
>> 12 parts per million is pretty good. Is that cumulative deviation 
>> from 'wall
>> time' over ~12 hours?
>>
> yes, deviation between the guest's time and an ntp reference.
>
>> That could easily be explained by the fact that Xen
>> system time is not sync'ed with ntp.
>>  
>>
> That's true. And, as we have discussed, this error seems to vary quite 
> a bit
> platform to platform for some reason. I will verify that this still is 
> the case.
>
> -Dave
>
>> -- Keir
>>
>>
>>  
>>
>


--------------090501030308050902050601
Content-Type: text/plain;
 name="p.calib.order"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="p.calib.order"

diff -r 483d006cc607 xen/arch/x86/time.c
--- a/xen/arch/x86/time.c	Fri Apr 25 13:46:27 2008 +0100
+++ b/xen/arch/x86/time.c	Fri Apr 25 15:40:31 2008 -0400
@@ -836,9 +836,9 @@ static void local_time_calibration(void 
 
     /* Disable IRQs to get 'instantaneous' current timestamps. */
     local_irq_disable();
+    curr_master_stime = read_platform_stime();
+    curr_local_stime  = get_s_time();
     rdtscll(curr_tsc);
-    curr_local_stime  = get_s_time();
-    curr_master_stime = read_platform_stime();
     local_irq_enable();
 
 #if 0

--------------090501030308050902050601
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--------------090501030308050902050601--