From: Ulrich Drepper <drepper@redhat.com>
To: Ryan Harper <ryanh@us.ibm.com>
Cc: kvm-devel@lists.sourceforge.net, Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH] Fix QEMU vcpu thread race with apic_reset
Date: Sat, 26 Apr 2008 09:58:43 -0700 [thread overview]
Message-ID: <48135F43.5080407@redhat.com> (raw)
In-Reply-To: <1209187574-21081-1-git-send-email-ryanh@us.ibm.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Ryan Harper wrote:
> + /* block until cond_wait occurs */
> + pthread_mutex_lock(&vcpu_mutex);
> + /* now we can signal */
> + pthread_cond_signal(&qemu_vcpuup_cond);
> + pthread_mutex_unlock(&vcpu_mutex);
It is not necessary to take the mutex for a condvar if you're just
waking a waiter. This just unnecessarily slows things down.
- --
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
iD8DBQFIE19D2ijCOnn/RHQRAvLqAJ9j+7ICPHpB/gCthCelDgYn5poGMgCfaZVy
+tE5zOuxqlBMUR7Fgufw/wY=
=5j4s
-----END PGP SIGNATURE-----
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel
next prev parent reply other threads:[~2008-04-26 16:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-26 5:26 [PATCH] Fix QEMU vcpu thread race with apic_reset Ryan Harper
2008-04-26 5:33 ` Ryan Harper
2008-04-26 7:16 ` Avi Kivity
2008-04-28 16:26 ` Ryan Harper
2008-04-28 20:02 ` Anthony Liguori
2008-04-29 0:46 ` Ulrich Drepper
2008-04-26 16:58 ` Ulrich Drepper [this message]
2008-04-26 17:04 ` Ulrich Drepper
2008-04-26 17:56 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48135F43.5080407@redhat.com \
--to=drepper@redhat.com \
--cc=avi@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=ryanh@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.