From: Avi Kivity <avi@qumranet.com>
To: "Yang, Sheng" <sheng.yang@intel.com>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>
Subject: Re: [PATCH 4/8] KVM: MMU: Add EPT support
Date: Sun, 27 Apr 2008 12:35:00 +0300 [thread overview]
Message-ID: <481448C4.6000104@qumranet.com> (raw)
In-Reply-To: <200804251625.57245.sheng.yang@intel.com>
Yang, Sheng wrote:
> From 239f38236196c2321989c64d7c61ff28490b3f00 Mon Sep 17 00:00:00 2001
> From: Sheng Yang <sheng.yang@intel.com>
> Date: Fri, 25 Apr 2008 21:13:50 +0800
> Subject: [PATCH 4/8] KVM: MMU: Add EPT support
>
> Enable kvm_set_spte() to generate EPT entries.
>
>
> @@ -1155,7 +1178,7 @@ static int __direct_map(struct kvm_vcpu *vcpu, gpa_t v,
> int write,
> }
>
> table[index] = __pa(new_table->spt) | PT_PRESENT_MASK
> - | PT_WRITABLE_MASK | PT_USER_MASK;
> + | PT_WRITABLE_MASK | shadow_user_mask;
> }
>
Shouldn't we have shadow_x_mask here as well?
[and for non-EPT, shadow_accessed_mask and shadow_dirty_mask, but that's
a different story].
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
prev parent reply other threads:[~2008-04-27 9:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-25 8:25 [PATCH 4/8] KVM: MMU: Add EPT support Yang, Sheng
2008-04-27 9:35 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481448C4.6000104@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=sheng.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.