From: "Jan Beulich" <jbeulich@novell.com>
To: Gang Wei <gang.wei@intel.com>
Cc: xen-devel@lists.xensource.com
Subject: RE: [PATCH 1/9] Add cpu idle pwr mgmt to xen
Date: Mon, 28 Apr 2008 10:24:58 +0100 [thread overview]
Message-ID: <4815B40A.76E4.0078.0@novell.com> (raw)
In-Reply-To: <094BCE01AFBE9646AF220B0B3F367AAB02FE2EC4@pdsmsx413.ccr.corp.intel.com>
>>> "Wei, Gang" <gang.wei@intel.com> 26.04.08 11:55 >>>
>Revised according to Keir's comments. Resubmit.
Some comments regarding the compat guest handling: You cannot
validly set_xen_guest_handle() on space coming from xmalloc. It is
the purpose of the per-vCPU argument translation page to deal with
that (i.e. the translated arguments go into that page, subject to your
own management of how you assign space for the individual (sub-)
hypercall's arguments).
Further, you shouldn't manually copy fields, this should be done
through the machine generated macros in xen/include/compat/xlat.h,
which would require you to add the structures needing translation to
xen/include/xlat.lst.
Jan
next prev parent reply other threads:[~2008-04-28 9:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-25 5:07 [PATCH 1/9] Add cpu idle pwr mgmt to xen Wei, Gang
2008-04-25 13:00 ` Keir Fraser
2008-04-25 13:29 ` Wei, Gang
2008-04-26 9:55 ` Wei, Gang
2008-04-28 9:24 ` Jan Beulich [this message]
2008-04-30 3:27 ` Wei, Gang
2008-04-30 7:22 ` Jan Beulich
2008-04-30 8:54 ` Keir Fraser
2008-04-30 9:08 ` Wei, Gang
2008-04-30 9:12 ` Tian, Kevin
2008-04-30 9:18 ` Tian, Kevin
2008-04-30 9:35 ` Jan Beulich
2008-04-30 9:42 ` Tian, Kevin
2008-04-30 10:00 ` Keir Fraser
2008-04-30 10:25 ` Jan Beulich
2008-04-30 12:27 ` Keir Fraser
2008-04-30 10:25 ` Jan Beulich
2008-05-05 6:34 ` Tian, Kevin
2008-04-30 16:36 ` Wei, Gang
2008-05-01 0:48 ` Wei, Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4815B40A.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=gang.wei@intel.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.