From: "H. Peter Anvin" <hpa@zytor.com>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
David Woodhouse <dwmw2@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86: vm86 - hide X86_VM_MASK from userland programs v2
Date: Tue, 29 Apr 2008 08:46:09 -0700 [thread overview]
Message-ID: <481742C1.5040709@zytor.com> (raw)
In-Reply-To: <20080429154330.GC6837@cvg>
Cyrill Gorcunov wrote:
> |
> | with this patch we have <asm/vm86.h> included only
> | if __i386__ defined *BUT* X86_VM_MASK is tried to be
> | used *without* __386__ being checked (as example - ptrace.h:user_mode_vm).
> | I'm not sure how to properly hanle this situation. But will take a look.
> |
> | So I suggest you drop my last patch (which moves X86_VM_MASK
> | into __KERNEL__ section) for a while. I'll recheck all
> | this stuff later (too busy now).
> |
> | - Cyrill -
>
> Thomas, could you take a look please - is my suspicious wrong?
>
> - Cyrill -
X86_VM_MASK should be defined to zero on x86-64. Part of the reason for
this symbol is so we don't have to put #ifdef around its uses.
-hpa
next prev parent reply other threads:[~2008-04-29 15:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-24 14:41 [PATCH] x86: vm86 - hide X86_VM_MASK from userland programs v2 Cyrill Gorcunov
2008-04-24 18:06 ` H. Peter Anvin
2008-04-28 18:23 ` Ingo Molnar
2008-04-28 19:20 ` Ingo Molnar
2008-04-29 13:36 ` Cyrill Gorcunov
2008-04-29 15:29 ` Cyrill Gorcunov
2008-04-29 15:43 ` Cyrill Gorcunov
2008-04-29 15:46 ` H. Peter Anvin [this message]
2008-04-29 16:01 ` Cyrill Gorcunov
2008-04-29 16:08 ` Cyrill Gorcunov
2008-04-29 17:44 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481742C1.5040709@zytor.com \
--to=hpa@zytor.com \
--cc=dwmw2@infradead.org \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.