Re: lock reclaims outside grace period

[Wendy Cheng <s.wendy.cheng@gmail.com>]

J. Bruce Fields wrote:
> On Tue, Apr 29, 2008 at 03:18:51PM -0700, Trond Myklebust wrote:
>   
>> On Tue, 2008-04-29 at 17:57 -0400, J. Bruce Fields wrote:
>>     
>>> Current lockd code appears to reject regular locks done during the grace
>>> period, but not reclaims that come outside of the grace period.
>>>
>>> (That's based on inspecting the code--I haven't run tests.)
>>>
>>> That seems like an obvious bug.  (We're not giving the client any way to
>>> determine whether conflicting locks might have been granted.)
>>>
>>> Can we fix it, or is there a chance that people have been depending on
>>> this behavior?  (Maybe for failing over to an already-active server??)
>>>       
>> Sorry, but I really don't care if anyone has been relying on it: that is
>> a _major_ bug and needs to be fixed ASAP.
>>     
>
> OK, good, I'll do some tests to confirm and then submit a patch.
>   

I can't disagree - but do prepare people start to ask why after kernel 
version 2.6.x, they have to extend grace period to get NFS locking works 
:) ...

-- Wendy