From: Vladimir Koutny <vlado@work.ksp.sk>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: bruno randolf <bruno@thinktube.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFC] WARNING: at net/mac80211/ieee80211_rate.h:159 rate_lowest_index()
Date: Wed, 30 Apr 2008 17:46:59 +0200 [thread overview]
Message-ID: <48189473.8060506@work.ksp.sk> (raw)
In-Reply-To: <1209567945.18659.35.camel@johannes.berg>
[-- Attachment #1: Type: text/plain, Size: 654 bytes --]
Johannes Berg wrote:
>> Yes, that would be a reasonable option - providing that we have the rate
>> (which we should - there is a WARN_ON(1) in rx-path if it is not set correctly)
>
> the packet is also dropped in that case so you don't see it.
Oh yes. Should have read one more line of code :)
>
>> As I think about that, I would suggest:
>> - no sta info is being collected prior to join/create
>> - sta entry is added/updated on each beacon with reported rateset
>> - sta entry is added/updated on data frames with just the received-rate
>
> Want to do the patch?
I'll try. Hope we have rx-rate on hand where needed :)
Vlado
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 370 bytes --]
next prev parent reply other threads:[~2008-04-30 15:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-29 16:01 [RFC] WARNING: at net/mac80211/ieee80211_rate.h:159 rate_lowest_index() Vladimir Koutny
2008-04-29 18:42 ` bruno randolf
2008-04-30 15:03 ` Vladimir Koutny
2008-04-30 15:05 ` Johannes Berg
2008-04-30 15:46 ` Vladimir Koutny [this message]
2008-04-30 14:20 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48189473.8060506@work.ksp.sk \
--to=vlado@work.ksp.sk \
--cc=bruno@thinktube.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.