All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Mark Lord <liml@rtr.ca>
Cc: Jeff Garzik <jgarzik@pobox.com>,
	IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: Re: libata-eh/pmp command sequence on NCQ media error
Date: Thu, 01 May 2008 11:55:52 +0900	[thread overview]
Message-ID: <48193138.2070306@gmail.com> (raw)
In-Reply-To: <48192ED5.9030402@rtr.ca>

Mark Lord wrote:
> Tejun Heo wrote:
>> Mark Lord wrote:
>>>> So why are we taking a hammer to things there?
>>
>> Hmmm... The reset action might be too heavy handed but maybe keeping 
>> that categorized as ATA bus error is still a good idea so that 
>> multiple errors w/ that bit set can trigger speed down.
>>
>>> FWIW, this patch fixes it for me (and fixes a misleading printk).
>>> Or I could just clear that bit from sata_mv before invoking EH.
>>> (??)
>>
>> Does the bit get set for the host link or pmp fanout links?
> ..
> 
> It's only on the pmp fanout link. Dunno why it gets set, but it does.

Which PMP are you using?  I've never seen something like that.  If it's 
on fan-out port, you'll want to implement a quirk in libata-pmp.c as it 
will probably happen with other controllers too.

Thanks.

-- 
tejun

  reply	other threads:[~2008-05-01  2:55 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-23 20:33 [PATCH] libata-eh copy result_tf flags from outgoing tf Mark Lord
2008-04-23 22:14 ` Tejun Heo
2008-04-23 23:37   ` Mark Lord
2008-04-24  1:02     ` Tejun Heo
2008-04-24  2:24       ` Mark Lord
2008-04-24  2:43         ` Tejun Heo
2008-04-24  2:36       ` Mark Lord
2008-04-24  2:42         ` Tejun Heo
2008-04-24  2:36 ` [PATCH] libata-eh set tf flags in NCQ EH result_tf Mark Lord
2008-04-24  2:43   ` Tejun Heo
2008-04-25  5:15   ` Jeff Garzik
2008-04-25 13:56     ` libata-eh/pmp command sequence on NCQ media error Mark Lord
2008-04-25 16:10       ` Tejun Heo
2008-04-25 16:34         ` Mark Lord
2008-04-30 21:33         ` Mark Lord
2008-04-30 21:40           ` Mark Lord
2008-04-30 21:52             ` Mark Lord
2008-05-01  0:51             ` Tejun Heo
2008-05-01  2:45               ` Mark Lord
2008-05-01  2:55                 ` Tejun Heo [this message]
2008-05-01  3:47                   ` Mark Lord
2008-05-01 11:24                   ` Mark Lord
2008-05-01 12:24                     ` Tejun Heo
2008-05-01 12:33                       ` Mark Lord
2008-05-01 12:40                         ` Tejun Heo
2008-05-01  2:48               ` Mark Lord
2008-05-01  2:54                 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48193138.2070306@gmail.com \
    --to=htejun@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=liml@rtr.ca \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.