All of lore.kernel.org
 help / color / mirror / Atom feed
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Paul Menage <menage@google.com>
Cc: Dhaval Giani <dhaval@linux.vnet.ibm.com>,
	vivk@us.ibm.com, Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Balbir Singh <balbir@in.ibm.com>,
	Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
	lkml <linux-kernel@vger.kernel.org>,
	libcg-devel <libcg-devel@lists.sourceforge.net>,
	Balaji Rao <balajirrao@gmail.com>
Subject: Re: [Libcg-devel] cgroupstats, plans?
Date: Fri, 02 May 2008 14:44:14 +0530	[thread overview]
Message-ID: <481ADB66.1010007@linux.vnet.ibm.com> (raw)
In-Reply-To: <6599ad830805011852t7dc6de32qd4c105a51c2fee06@mail.gmail.com>

Paul Menage wrote:
> On Tue, Apr 29, 2008 at 5:20 AM, Dhaval Giani <dhaval@linux.vnet.ibm.com> wrote:
>> Hi Paul,
>>
>>  You had mentioned in http://lkml.org/lkml/2008/4/8/29 about cgroup
>>  binary API for statistics. What is the status wrt to that?
> 
> I've not really had mmore time to work on that since then.
> 
> Assuming people are happy with the basic ideas in that post then I
> guess the important questions to focus on would be:
> 
> - what form should the API description to userspace take? Something
> like the cgroup.api file that I proposed a while ago?
> 
> - how would the user specify and retrieve a specific set of stats?
> should we just dump all stats on each read request, or will that be
> too expensive for some stats?
> 

I would prefer to select the controller from user stats and then dump the stats
from the kernel for that controller using cgroupstats.

>>  We are looking to export statistics using libcg. One of the questions
>>  that comes up is when is a file in the cgroup, a control file (one used
>>  to control the parameters of the subsystem) and when is it a file which
>>  is related to statistics.
> 
> I don't see why some of them can't be both. If a file has a numerical
> value associated with it, is there any reason not to make it available
> via the binary stats API, regardless of whether that value was
> generated by userspace or the kernel?
> 

I agree. I think we need to start pushing the statistics so that we can have a
good set of statistics. I am going to try and do some cgroupstats work and
publish it soon.

-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL

  reply	other threads:[~2008-05-02  9:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-29 12:20 cgroupstats, plans? Dhaval Giani
2008-05-02  1:52 ` Paul Menage
2008-05-02  9:14   ` Balbir Singh [this message]
2008-05-13  6:10     ` [Libcg-devel] " Paul Menage

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=481ADB66.1010007@linux.vnet.ibm.com \
    --to=balbir@linux.vnet.ibm.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=balajirrao@gmail.com \
    --cc=balbir@in.ibm.com \
    --cc=dhaval@linux.vnet.ibm.com \
    --cc=libcg-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menage@google.com \
    --cc=vatsa@linux.vnet.ibm.com \
    --cc=vivk@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.