All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: "Jörn Engel" <joern@lazybastard.org>, "Andrew Morton" <akpm@osdl.org>
Subject: [PATCH] fix checkstack.pl arch detection
Date: Fri, 02 May 2008 12:20:53 -0500	[thread overview]
Message-ID: <481B4D75.9060305@redhat.com> (raw)

uname -m was leaving a newline in $arch, and not passing the tests.

Also, printing the unknown arch on failure is probably helpful.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

Index: linux-2.6.25/scripts/checkstack.pl
===================================================================
--- linux-2.6.25.orig/scripts/checkstack.pl	2008-05-02 12:17:59.000000000 -0500
+++ linux-2.6.25/scripts/checkstack.pl	2008-05-02 12:18:15.426407528 -0500
@@ -32,6 +32,7 @@ my (@stack, $re, $x, $xs);
 	my $arch = shift;
 	if ($arch eq "") {
 		$arch = `uname -m`;
+		chomp($arch);
 	}
 
 	$x	= "[0-9a-f]";	# hex character
@@ -85,7 +86,7 @@ my (@stack, $re, $x, $xs);
 		#   0:   00 e8 38 01     LINK 0x4e0;
 		$re = qr/.*[[:space:]]LINK[[:space:]]*(0x$x{1,8})/o;
 	} else {
-		print("wrong or unknown architecture\n");
+		print("wrong or unknown architecture \"$arch\"\n");
 		exit
 	}
 }


             reply	other threads:[~2008-05-02 17:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-02 17:20 Eric Sandeen [this message]
2008-05-02 22:37 ` [PATCH] fix checkstack.pl arch detection Jörn Engel
2008-05-02 23:44   ` Andrew Morton
2008-05-03  2:20     ` Eric Sandeen
2008-05-03  2:31       ` Andrew Morton
2008-05-03  2:40         ` Eric Sandeen
2008-05-03  2:51           ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=481B4D75.9060305@redhat.com \
    --to=sandeen@redhat.com \
    --cc=akpm@osdl.org \
    --cc=joern@lazybastard.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.