From: "H. Peter Anvin" <hpa@zytor.com>
To: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: x86 git acpi issue?
Date: Fri, 02 May 2008 17:08:12 -0700 [thread overview]
Message-ID: <481BACEC.8080902@zytor.com> (raw)
In-Reply-To: <481BAC6F.5090509@ct.jp.nec.com>
Hiroshi Shimamoto wrote:
> Hi,
>
> commit: afcab879e4044f952b7a031d5fd504e0feb7df41
> visws: build fix
>
> breaks something around acpi on 32bit.
> In my test box scsi driver complains and the kernel doesn't boot.
>
> I'm not sure, but when moving the acpi.o before legacy.o, it works.
> --- a/arch/x86/pci/Makefile_32
> +++ b/arch/x86/pci/Makefile_32
> @@ -6,11 +6,11 @@ obj-$(CONFIG_PCI_DIRECT) += direct.o
> obj-$(CONFIG_PCI_OLPC) += olpc.o
>
> pci-y := fixup.o
> +pci-$(CONFIG_ACPI) += acpi.o
> pci-y += legacy.o irq.o
>
> pci-$(CONFIG_X86_VISWS) := visws.o fixup.o
> pci-$(CONFIG_X86_NUMAQ) := numa.o irq.o
> -pci-$(CONFIG_ACPI) += acpi.o
> pci-$(CONFIG_NUMA) += mp_bus_to_node.o
>
> obj-y += $(pci-y) common.o early.o
>
> of cause this isn't correct patch, it's just a workaround for me.
>
The problem is that := should be += for the VISWS and NUMAQ lines.
There is already a patch queued up to fix that.
-hpa
next prev parent reply other threads:[~2008-05-03 0:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-03 0:06 x86 git acpi issue? Hiroshi Shimamoto
2008-05-03 0:08 ` H. Peter Anvin [this message]
2008-05-03 0:30 ` Hiroshi Shimamoto
2008-05-03 7:13 ` Adrian Bunk
2008-05-03 9:27 ` Thomas Gleixner
2008-05-03 9:45 ` Ingo Molnar
2008-05-03 10:02 ` Thomas Gleixner
2008-05-03 10:08 ` Sam Ravnborg
2008-05-03 11:10 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481BACEC.8080902@zytor.com \
--to=hpa@zytor.com \
--cc=h-shimamoto@ct.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.