From: Pavel Emelyanov <xemul@openvz.org>
To: Chas Williams <chas@cmf.nrl.navy.mil>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: [PATCH 1/2][ATM]: Do not free already unregistered net device.
Date: Sun, 04 May 2008 11:37:43 +0400 [thread overview]
Message-ID: <481D67C7.5050909@openvz.org> (raw)
Both br2684_push and br2684_exit do so, but unregister_netdev()
releases the device itself.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
---
net/atm/br2684.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/net/atm/br2684.c b/net/atm/br2684.c
index 1b22806..3a74ff8 100644
--- a/net/atm/br2684.c
+++ b/net/atm/br2684.c
@@ -350,7 +350,6 @@ static void br2684_push(struct atm_vcc *atmvcc, struct sk_buff *skb)
list_del(&brdev->br2684_devs);
read_unlock(&devs_lock);
unregister_netdev(net_dev);
- free_netdev(net_dev);
}
return;
}
@@ -771,7 +770,6 @@ static void __exit br2684_exit(void)
list_del(&brdev->br2684_devs);
unregister_netdev(net_dev);
- free_netdev(net_dev);
}
}
--
1.5.3.4
next reply other threads:[~2008-05-04 7:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-04 7:37 Pavel Emelyanov [this message]
2008-05-05 1:00 ` [PATCH 1/2][ATM]: Do not free already unregistered net device David Miller
-- strict thread matches above, loose matches on Subject: below --
2008-05-05 16:44 Don Fry
2008-05-05 19:37 ` David Miller
2008-05-06 6:34 ` Pavel Emelyanov
2008-05-06 6:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481D67C7.5050909@openvz.org \
--to=xemul@openvz.org \
--cc=chas@cmf.nrl.navy.mil \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.