From: Rene Herman <rene.herman@keyaccess.nl>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>,
Joe Perches <joe@perches.com>,
linux-next@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH -next] PNP: fix printk format warnings
Date: Sun, 04 May 2008 23:40:05 +0200 [thread overview]
Message-ID: <481E2D35.6080600@keyaccess.nl> (raw)
In-Reply-To: <481E2535.8080301@oracle.com>
On 04-05-08 23:05, Randy Dunlap wrote:
> My original patch did (int) cast but Joe suggested using unsigned long
> long. I didn't expect DMA channel or irq to be anywhere near that large,
> so I thought that (int) would be sufficient, at the same time recognizing
> that it does/could truncate the value, while ull won't truncate.
Yes, (int) would've been fine. It's (int) in PnPACPI as well which is what I
remebered seeing. Doesn't matter much ofcourse.
Rene.
prev parent reply other threads:[~2008-05-04 21:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 20:56 [PATCH -next] PNP: fix printk format warnings Randy Dunlap
2008-04-30 21:07 ` Joe Perches
2008-04-30 21:25 ` Randy Dunlap
2008-05-04 19:18 ` Rene Herman
2008-05-04 21:05 ` Randy Dunlap
2008-05-04 21:40 ` Rene Herman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481E2D35.6080600@keyaccess.nl \
--to=rene.herman@keyaccess.nl \
--cc=akpm@linux-foundation.org \
--cc=bjorn.helgaas@hp.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.