All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: dor.laor@qumranet.com
Cc: kvm-devel@lists.sourceforge.net,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH 3/3] Stop dropping so many RX packets in tap (v2)
Date: Sun, 04 May 2008 17:53:27 -0500	[thread overview]
Message-ID: <481E3E67.6020904@codemonkey.ws> (raw)
In-Reply-To: <1209939229.24261.81.camel@localhost.localdomain>

Dor Laor wrote:
> On Sun, 2008-05-04 at 15:21 -0500, Anthony Liguori wrote:
>   
> Patchset looks good and reduces some nasty hacks. It probably also
> improves other devices like e1000 et al.
>   

Yeah, we just need to make sure they have proper can_receive handlers.  
I took a quick look at the e1000 but it wasn't entirely obvious to me 
how RX packets get queued.  AFAICT, the e1000 can_receive handler only 
reports false when the device isn't initialized so it's likely it's 
dropping packets.

Regards,

Anthony Liguori

> Cheers,
> Dor
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
> Don't miss this year's exciting event. There's still time to save $100. 
> Use priority code J8TL2D2. 
> http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
> _______________________________________________
> kvm-devel mailing list
> kvm-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/kvm-devel
>   


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone

      reply	other threads:[~2008-05-04 22:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-04 20:21 [PATCH 1/3] Revert virtio tap hack (v2) Anthony Liguori
2008-05-04 20:21 ` [PATCH 2/3] Make virtio-net can_receive more accurate (v2) Anthony Liguori
2008-05-04 20:21 ` [PATCH 3/3] Stop dropping so many RX packets in tap (v2) Anthony Liguori
2008-05-04 22:13   ` Dor Laor
2008-05-04 22:53     ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=481E3E67.6020904@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=avi@qumranet.com \
    --cc=dor.laor@qumranet.com \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.