From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757784AbYEEKX5 (ORCPT ); Mon, 5 May 2008 06:23:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753771AbYEEKXt (ORCPT ); Mon, 5 May 2008 06:23:49 -0400 Received: from one.firstfloor.org ([213.235.205.2]:50082 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752229AbYEEKXs (ORCPT ); Mon, 5 May 2008 06:23:48 -0400 Message-ID: <481EE031.3090303@firstfloor.org> Date: Mon, 05 May 2008 12:23:45 +0200 From: Andi Kleen User-Agent: Thunderbird 1.5.0.12 (X11/20060911) MIME-Version: 1.0 To: Thomas Gleixner CC: mingo@elte.hu, linux-kernel@vger.kernel.org Subject: Re: [PATCH REPOST] CPA: Add statistics about state of direct mapping v4 References: <20080502094649.GA11185@basil.nowhere.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> +static unsigned long direct_pages_count[PG_LEVEL_NUM]; >> + >> +void __meminit update_page_count(int level, unsigned long pages) > > Why __meminit ? This is used in split_large_page() True. Can you please just remove it? I think it came when this was still only used in early memory init. [insert standard rant about the work:code size benefit ratio of these fine grained section identifiers being far too high] >> +{ >> +#ifdef CONFIG_PROC_FS > > Why keep an empty function when PROC_FS is disabled ? So we don't have to add a ifdef in all the callers. Yes could probably have an empty inline in that case in some header, but frankly that would be a lot of code lines for saving only very minor code size in a very unlikely CONFIG case. -Andi