Re: [PATCH] i386: Execute stack overflow warning on interrupt stack II

[Eric Sandeen <sandeen@sandeen.net>]

Thomas Gleixner wrote:
> On Mon, 5 May 2008, Andi Kleen wrote:
>> Thomas Gleixner wrote:
>>> On Fri, 2 May 2008, Andi Kleen wrote:
>>>> +static void stack_overflow(void)
>>>> +{
>>>> +	printk("low stack detected by irq handler\n");
>>> Needs a KERN_ERR
>> Just moving code. If there is one added it should be in another patch.
> 
> Err, you are not moving code. The printk is pretty different and
> adding the KERN_xx in the same go is nothing which makes the patch
> harder to understand.
> 
>> Besides if anything it's a KERN_WARN I guess.
> 
> KERN_WARN is fine, even if I consider a stack overflow as an error.

But it hasn't overflowed yet.  It's a warning about being *close* - not
an error.

-Eric