All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: Anders <mail@flac.kalibalik.dk>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [4341] qemu: generate signals on tap I/O
Date: Tue, 06 May 2008 00:15:15 +0200	[thread overview]
Message-ID: <481F86F3.4080007@aurel32.net> (raw)
In-Reply-To: <481F84F3.6060505@flac.kalibalik.dk>

Anders a écrit :
> Aurelien Jarno wrote:
>> --- trunk/vl.c    2008-05-05 21:26:31 UTC (rev 4340)
>> +++ trunk/vl.c    2008-05-05 21:26:43 UTC (rev 4341)
>> @@ -4030,6 +4030,7 @@
>>      if (!s)
>>          return NULL;
>>      s->fd = fd;
>> +    enable_sigio_timer(fd);
>>      s->vc = qemu_new_vlan_client(vlan, tap_receive, NULL, s);
>>      qemu_set_fd_handler(s->fd, tap_send, NULL, s);
>>      snprintf(s->vc->info_str, sizeof(s->vc->info_str), "tap: fd=%d", fd)
> 
> Hm, I think this will break on BSD, as the function is only available in
> Linux?

That's why I reverted that commit, it was for my local tree only, I
committed it accidentally (along with a few other patches).

> I posted a more complete implementation a few weeks ago, anything wrong
> with it?
> 
> http://thread.gmane.org/gmane.comp.emulators.qemu/24567

People saying it is not the way to go, and I have still haven't decided
myself if it is a correct solution or not.

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net

  reply	other threads:[~2008-05-05 22:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-05 21:26 [Qemu-devel] [4341] qemu: generate signals on tap I/O Aurelien Jarno
2008-05-05 22:06 ` Anders
2008-05-05 22:15   ` Aurelien Jarno [this message]
2008-05-05 22:42     ` Anders
2008-05-05 22:44       ` Anthony Liguori
2008-05-05 22:49         ` Aurelien Jarno
2008-05-05 22:51           ` Aurelien Jarno
2008-05-05 22:57             ` Anthony Liguori
2008-05-05 23:00               ` Anthony Liguori
2008-05-05 23:12         ` Anders
2008-05-06  2:48           ` Anthony Liguori
2008-05-06  8:35             ` Anders
2008-05-05 22:50       ` Anthony Liguori
2008-05-05 22:43 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=481F86F3.4080007@aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=mail@flac.kalibalik.dk \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.