From: Pavel Emelyanov <xemul@openvz.org>
To: David Miller <davem@davemloft.net>
Cc: pcnet32@verizon.net, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2][ATM]: Do not free already unregistered net device.
Date: Tue, 06 May 2008 10:34:38 +0400 [thread overview]
Message-ID: <481FFBFE.4020900@openvz.org> (raw)
In-Reply-To: <20080505.123703.257416714.davem@davemloft.net>
David Miller wrote:
> From: Don Fry <pcnet32@verizon.net>
> Date: Mon, 05 May 2008 09:44:40 -0700
>
>> I do not understand why this change was accepted. All of the network
>> drivers I just looked at in 2.6.25 do unregister_netdev() followed
>> sometime soon by free_netdev(). Is there something different about ATM
>> devices? I did not look at all the drivers.
>
> Indeed, this change does look bogus.
>
> Pavel, please take a look, unregister_netdev() indeed does not free
> the netdevice, and something (usually the caller) needs to do it.
Indeed :( My bad, I've overlooked the fact, that this device doesn't
have a ->destructor callback set (which most of the others set to the
free_netdev), so the free_netdev is to be called manually.
> I think I should revert your change.
Agree. Sorry, for the confusion.
next prev parent reply other threads:[~2008-05-06 6:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 16:44 [PATCH 1/2][ATM]: Do not free already unregistered net device Don Fry
2008-05-05 19:37 ` David Miller
2008-05-06 6:34 ` Pavel Emelyanov [this message]
2008-05-06 6:58 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2008-05-04 7:37 Pavel Emelyanov
2008-05-05 1:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481FFBFE.4020900@openvz.org \
--to=xemul@openvz.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pcnet32@verizon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.