From: Patrick McHardy <kaber@trash.net>
To: Arnaud Ebalard <arno@natisbad.org>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Netfilter Developer Mailing List
<netfilter-devel@vger.kernel.org>
Subject: Re: [RESEND][NETFILTER][PATCH] nfqnl_mangle() not requesting enough space for bigger reinjected packet.
Date: Tue, 06 May 2008 12:18:33 +0200 [thread overview]
Message-ID: <48203079.60001@trash.net> (raw)
In-Reply-To: <87zlrdtw6q.fsf@natisbad.org>
Arnaud Ebalard wrote:
> BTW, while looking at the code, I noticed the call to skb_copy_expand()
> leads to a complete copy of current sk_buff data to the new sk_buff.
> Those data are then completely rewritten a few lines later. Too bad
> there is no simple way (considering skbuff.h) to prevent the useless
> copy.
Yeah, thats a bit unfortunate. I don't see how we could avoid
this besides allocating a fresh skb and setting up all the meta
data manually though.
prev parent reply other threads:[~2008-05-06 10:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 17:49 [RESEND][NETFILTER][PATCH] nfqnl_mangle() not requesting enough space for bigger reinjected packet Arnaud Ebalard
2008-04-28 21:56 ` Patrick McHardy
2008-04-28 23:07 ` Arnaud Ebalard
2008-05-06 10:18 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48203079.60001@trash.net \
--to=kaber@trash.net \
--cc=arno@natisbad.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.