From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B79B2F7F1D for ; Tue, 7 Jul 2026 19:02:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783450956; cv=none; b=UYr1Anh0u4+wc0OGmomWrABG5JTDKY7J7VIy3MOPeEVa7GGvGCXhNX3aDq8N9JejsjguDdaZmfokjNFVmaR5KPFnXvFheNmx06olgD//EF28P8LaigT4slgREdt8tpD6841pdIpcn9LJ09os2Dznp7IZagf2zxt8NSuN3JMbh8c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783450956; c=relaxed/simple; bh=pBmhv52fyWHgbSBWdBvZitDB9EPq6Rj5L83OcMziSkg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XASHKBnCan4pZyr6dsg51tiAMNe7Rum0JOTmhLwpgrG9Hk2WXwbHzrEiHzyrEhbjSuPdb5JVsuOBaZn105sSN5+qY8An6aCjMuyJMMRaElIHSxOaseaVgYt7+Il8tfhNgf8rfy/Ed1kS+SnMhvFXSzlwkqN5G1lYrslWVqc0E5g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=IcdSnAl0; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="IcdSnAl0" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=0VgqZk2+M4O8X70VgHeDWO5bVKrL7Qb344B9KtlXxf0=; b=IcdSnAl0GWmvivyH9PIGEfrrG/ m+vhRS1GrEpSZnu3BwWkB0bW+kHnF1uCU4b0j8snGm8yeWJwaeo0EXqHRVrD4/uIgY/kP4qrDHYJW HWkGEbBSUPSeC+wC/4zOZBwpAgngtskkQx142Op/JWy93GHP3lNc7cP0NYr1gXG7IAn+qZGAOY/j1 T18dIjxuFJjTQZVAHJsccGj9xEZWnFUxizEVjfQEzdosal+0NkZaGJ1ofZNrZVZMU+fHObcoIgpDy 7GAorD5oPsPWJ8hdqKSvzTUEeqvi/65SFE+RxQQddNqr5h5pKFzbCC1XunfOZ+gExBV0Gt5sTpODv XNwL81ZQ==; From: Heiko Stuebner To: Brian Mayer Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] arm64: dts: rockchip: add HYM8563 RTC to Radxa CM5 IO board Date: Tue, 07 Jul 2026 21:02:30 +0200 Message-ID: <48203626.fMDQidcC6G@phil> In-Reply-To: <20260705181920.8633-1-bleemayer@gmail.com> References: <2960762.AiC22s8V5E@diego> <20260705181920.8633-1-bleemayer@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hi Brian, I've applied the change with some changes. Please the comments below in mind for future patches, but there is no need to send another version: Am Sonntag, 5. Juli 2026, 20:19:19 Mitteleurop=C3=A4ische Sommerzeit schrie= b Brian Mayer: > Hello again, to clarify: I tested the v1 patch in my radxa cm5, but since > this v2 only contains name changes I didn't test. I added the missing > agent tag and am sending the patch inline. Thanks. >=20 > The Radxa CM5 IO carrier has a Haoyu HYM8563 real-time clock on I2C6 at > address 0x51, with its interrupt line on GPIO0_B0 and a CR1220 backup > battery holder. Without a device tree node, no /dev/rtc* appears even > when CONFIG_RTC_DRV_HYM8563 is enabled. >=20 > Describe the RTC, wire the interrupt pin with a pull-up, mark it as a > wakeup source, and point the rtc0 alias at it so RTC_HCTOSYS/SYSTOHC use > the external clock. Wiring matches Radxa's downstream board support and > uses schematic names for the rtc_int_l pinctrl entry. Please way less AI fluff. The patch content show that you're wiring up the interrupt + pinctrl etc. Also, please no personal "Hello again ...." in the actual commit message. The text above is the text that ends up in the git log for your change, so should be short and to the point. I've shortened it to: =2D---- Describe the Haoyu HYM8563 RTC connected to I2C6 on the Radxa CM5 IO carrier including its interrupt line. =2D---- > Assisted-by: Grok:grok-build > Signed-off-by: Brian Mayer > --- Personal comments, remarks etc should be here, below the 3 dashes and above the diffstat. That way we can still read them, but they don't end up in the git history. > .../dts/rockchip/rk3588s-radxa-cm5-io.dts | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) >=20 > Changes in v2: > - Rename pinctrl to rtc_int_l / rtc-int-l to match schematics > - Drop Tested-by (covered by Signed-off-by) > - Add Assisted-by: Grok:grok-build > - Send inline with git send-email (not as attachment) >=20 > diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts b/arch= /arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts > index af4a9bc01..d22db4d18 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts > @@ -19,6 +19,7 @@ / { > aliases { > ethernet0 =3D &gmac1; > mmc1 =3D &sdmmc; > + rtc0 =3D &hym8563; > }; > =20 > chosen { > @@ -198,6 +199,18 @@ usbc0_dp_altmode_mux: endpoint { > }; > }; > }; > + > + hym8563: rtc@51 { > + compatible =3D "haoyu,hym8563"; > + reg =3D <0x51>; > + #clock-cells =3D <0>; > + clock-output-names =3D "hym8563"; > + interrupt-parent =3D <&gpio0>; > + interrupts =3D ; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&rtc_int_l>; > + wakeup-source; > + }; > }; > =20 > &i2s5_8ch { > @@ -221,6 +234,12 @@ usbc0_int: usbc0-int { > }; > }; > =20 > + hym8563 { > + rtc_int_l: rtc-int-l { > + rockchip,pins =3D <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_up>; > + }; > + }; > + please sort nodes alphabetically (hdmi -> hym8563) I did that when applying. Thanks Heiko > hdmi { > hdmi0_tx_on_h: hdmi0-tx-on-h { > rockchip,pins =3D <4 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>; >=20 > base-commit: 87320be9f0d24fce67631b7eef919f0b79c3e45c >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4922C43458 for ; Tue, 7 Jul 2026 19:02:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PzHIv7AqHBoAjQfdDkSoZr18d+fOQq0ydwq8Fem7wyo=; b=RRZK2VZmNJf0Yy RZvE5XBIZ17Mc9LRpJ2gftYbQ32a86GoYAp5Cs5kPLwcz5sWN20BGiR5R464m20AHny6bzeI05a4+ lnMgk84gB7jHkVzKn3DfaE6OK/WvJBQyTfvFsIsjwAxj78fPRLHeTNjE89akU/CxCm/49ibZCE7yC f0xTALf5QVMx9Cun36RPJ4oa/FSkBx8VRU9dG3/qBfR/Vds7ktWWsheTVHHk8HLqH+ud9BHm+cP0W U62Y+/9VdJQOTai6gGMNy+rCZvGjtTmXnjYYooizbhO/XuYtuOUULSQb0fktr+DD6gwXVV4hR1in9 u6axcWFLZFy018I0PzIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1whB43-0000000FgGh-1PRS; Tue, 07 Jul 2026 19:02:39 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1whB40-0000000FgFN-0Mvi; Tue, 07 Jul 2026 19:02:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=0VgqZk2+M4O8X70VgHeDWO5bVKrL7Qb344B9KtlXxf0=; b=IcdSnAl0GWmvivyH9PIGEfrrG/ m+vhRS1GrEpSZnu3BwWkB0bW+kHnF1uCU4b0j8snGm8yeWJwaeo0EXqHRVrD4/uIgY/kP4qrDHYJW HWkGEbBSUPSeC+wC/4zOZBwpAgngtskkQx142Op/JWy93GHP3lNc7cP0NYr1gXG7IAn+qZGAOY/j1 T18dIjxuFJjTQZVAHJsccGj9xEZWnFUxizEVjfQEzdosal+0NkZaGJ1ofZNrZVZMU+fHObcoIgpDy 7GAorD5oPsPWJ8hdqKSvzTUEeqvi/65SFE+RxQQddNqr5h5pKFzbCC1XunfOZ+gExBV0Gt5sTpODv XNwL81ZQ==; From: Heiko Stuebner To: Brian Mayer Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] arm64: dts: rockchip: add HYM8563 RTC to Radxa CM5 IO board Date: Tue, 07 Jul 2026 21:02:30 +0200 Message-ID: <48203626.fMDQidcC6G@phil> In-Reply-To: <20260705181920.8633-1-bleemayer@gmail.com> References: <2960762.AiC22s8V5E@diego> <20260705181920.8633-1-bleemayer@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260707_120236_133415_6424EFDD X-CRM114-Status: GOOD ( 24.95 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgQnJpYW4sCgpJJ3ZlIGFwcGxpZWQgdGhlIGNoYW5nZSB3aXRoIHNvbWUgY2hhbmdlcy4KUGxl YXNlIHRoZSBjb21tZW50cyBiZWxvdyBpbiBtaW5kIGZvciBmdXR1cmUgcGF0Y2hlcywgYnV0IHRo ZXJlIGlzIG5vCm5lZWQgdG8gc2VuZCBhbm90aGVyIHZlcnNpb246CgoKQW0gU29ubnRhZywgNS4g SnVsaSAyMDI2LCAyMDoxOToxOSBNaXR0ZWxldXJvcMOkaXNjaGUgU29tbWVyemVpdCBzY2hyaWVi IEJyaWFuIE1heWVyOgo+IEhlbGxvIGFnYWluLCB0byBjbGFyaWZ5OiBJIHRlc3RlZCB0aGUgdjEg cGF0Y2ggaW4gbXkgcmFkeGEgY201LCBidXQgc2luY2UKPiB0aGlzIHYyIG9ubHkgY29udGFpbnMg bmFtZSBjaGFuZ2VzIEkgZGlkbid0IHRlc3QuIEkgYWRkZWQgdGhlIG1pc3NpbmcKPiBhZ2VudCB0 YWcgYW5kIGFtIHNlbmRpbmcgdGhlIHBhdGNoIGlubGluZS4gVGhhbmtzLgo+IAo+IFRoZSBSYWR4 YSBDTTUgSU8gY2FycmllciBoYXMgYSBIYW95dSBIWU04NTYzIHJlYWwtdGltZSBjbG9jayBvbiBJ MkM2IGF0Cj4gYWRkcmVzcyAweDUxLCB3aXRoIGl0cyBpbnRlcnJ1cHQgbGluZSBvbiBHUElPMF9C MCBhbmQgYSBDUjEyMjAgYmFja3VwCj4gYmF0dGVyeSBob2xkZXIuIFdpdGhvdXQgYSBkZXZpY2Ug dHJlZSBub2RlLCBubyAvZGV2L3J0YyogYXBwZWFycyBldmVuCj4gd2hlbiBDT05GSUdfUlRDX0RS Vl9IWU04NTYzIGlzIGVuYWJsZWQuCj4gCj4gRGVzY3JpYmUgdGhlIFJUQywgd2lyZSB0aGUgaW50 ZXJydXB0IHBpbiB3aXRoIGEgcHVsbC11cCwgbWFyayBpdCBhcyBhCj4gd2FrZXVwIHNvdXJjZSwg YW5kIHBvaW50IHRoZSBydGMwIGFsaWFzIGF0IGl0IHNvIFJUQ19IQ1RPU1lTL1NZU1RPSEMgdXNl Cj4gdGhlIGV4dGVybmFsIGNsb2NrLiBXaXJpbmcgbWF0Y2hlcyBSYWR4YSdzIGRvd25zdHJlYW0g Ym9hcmQgc3VwcG9ydCBhbmQKPiB1c2VzIHNjaGVtYXRpYyBuYW1lcyBmb3IgdGhlIHJ0Y19pbnRf bCBwaW5jdHJsIGVudHJ5LgoKUGxlYXNlIHdheSBsZXNzIEFJIGZsdWZmLiBUaGUgcGF0Y2ggY29u dGVudCBzaG93IHRoYXQgeW91J3JlIHdpcmluZyB1cCB0aGUKaW50ZXJydXB0ICsgcGluY3RybCBl dGMuCgpBbHNvLCBwbGVhc2Ugbm8gcGVyc29uYWwgIkhlbGxvIGFnYWluIC4uLi4iIGluIHRoZSBh Y3R1YWwgY29tbWl0IG1lc3NhZ2UuClRoZSB0ZXh0IGFib3ZlIGlzIHRoZSB0ZXh0IHRoYXQgZW5k cyB1cCBpbiB0aGUgZ2l0IGxvZyBmb3IgeW91ciBjaGFuZ2UsCnNvIHNob3VsZCBiZSBzaG9ydCBh bmQgdG8gdGhlIHBvaW50LgoKSSd2ZSBzaG9ydGVuZWQgaXQgdG86Ci0tLS0tCkRlc2NyaWJlIHRo ZSBIYW95dSBIWU04NTYzIFJUQyBjb25uZWN0ZWQgdG8gSTJDNiBvbiB0aGUgUmFkeGEgQ001IElP CmNhcnJpZXIgaW5jbHVkaW5nIGl0cyBpbnRlcnJ1cHQgbGluZS4KLS0tLS0KCgo+IEFzc2lzdGVk LWJ5OiBHcm9rOmdyb2stYnVpbGQKPiBTaWduZWQtb2ZmLWJ5OiBCcmlhbiBNYXllciA8YmxlZW1h eWVyQGdtYWlsLmNvbT4KPiAtLS0KClBlcnNvbmFsIGNvbW1lbnRzLCByZW1hcmtzIGV0YyBzaG91 bGQgYmUgaGVyZSwgYmVsb3cgdGhlIDMgZGFzaGVzIGFuZAphYm92ZSB0aGUgZGlmZnN0YXQuIFRo YXQgd2F5IHdlIGNhbiBzdGlsbCByZWFkIHRoZW0sIGJ1dCB0aGV5IGRvbid0CmVuZCB1cCBpbiB0 aGUgZ2l0IGhpc3RvcnkuCgoKPiAgLi4uL2R0cy9yb2NrY2hpcC9yazM1ODhzLXJhZHhhLWNtNS1p by5kdHMgICAgIHwgMTkgKysrKysrKysrKysrKysrKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgMTkg aW5zZXJ0aW9ucygrKQo+IAo+IENoYW5nZXMgaW4gdjI6Cj4gLSBSZW5hbWUgcGluY3RybCB0byBy dGNfaW50X2wgLyBydGMtaW50LWwgdG8gbWF0Y2ggc2NoZW1hdGljcwo+IC0gRHJvcCBUZXN0ZWQt YnkgKGNvdmVyZWQgYnkgU2lnbmVkLW9mZi1ieSkKPiAtIEFkZCBBc3Npc3RlZC1ieTogR3Jvazpn cm9rLWJ1aWxkCj4gLSBTZW5kIGlubGluZSB3aXRoIGdpdCBzZW5kLWVtYWlsIChub3QgYXMgYXR0 YWNobWVudCkKPiAKPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9y azM1ODhzLXJhZHhhLWNtNS1pby5kdHMgYi9hcmNoL2FybTY0L2Jvb3QvZHRzL3JvY2tjaGlwL3Jr MzU4OHMtcmFkeGEtY201LWlvLmR0cwo+IGluZGV4IGFmNGE5YmMwMS4uZDIyZGI0ZDE4IDEwMDY0 NAo+IC0tLSBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvcm9ja2NoaXAvcmszNTg4cy1yYWR4YS1jbTUt aW8uZHRzCj4gKysrIGIvYXJjaC9hcm02NC9ib290L2R0cy9yb2NrY2hpcC9yazM1ODhzLXJhZHhh LWNtNS1pby5kdHMKPiBAQCAtMTksNiArMTksNyBAQCAvIHsKPiAgCWFsaWFzZXMgewo+ICAJCWV0 aGVybmV0MCA9ICZnbWFjMTsKPiAgCQltbWMxID0gJnNkbW1jOwo+ICsJCXJ0YzAgPSAmaHltODU2 MzsKPiAgCX07Cj4gIAo+ICAJY2hvc2VuIHsKPiBAQCAtMTk4LDYgKzE5OSwxOCBAQCB1c2JjMF9k cF9hbHRtb2RlX211eDogZW5kcG9pbnQgewo+ICAJCQl9Owo+ICAJCX07Cj4gIAl9Owo+ICsKPiAr CWh5bTg1NjM6IHJ0Y0A1MSB7Cj4gKwkJY29tcGF0aWJsZSA9ICJoYW95dSxoeW04NTYzIjsKPiAr CQlyZWcgPSA8MHg1MT47Cj4gKwkJI2Nsb2NrLWNlbGxzID0gPDA+Owo+ICsJCWNsb2NrLW91dHB1 dC1uYW1lcyA9ICJoeW04NTYzIjsKPiArCQlpbnRlcnJ1cHQtcGFyZW50ID0gPCZncGlvMD47Cj4g KwkJaW50ZXJydXB0cyA9IDxSS19QQjAgSVJRX1RZUEVfTEVWRUxfTE9XPjsKPiArCQlwaW5jdHJs LW5hbWVzID0gImRlZmF1bHQiOwo+ICsJCXBpbmN0cmwtMCA9IDwmcnRjX2ludF9sPjsKPiArCQl3 YWtldXAtc291cmNlOwo+ICsJfTsKPiAgfTsKPiAgCj4gICZpMnM1XzhjaCB7Cj4gQEAgLTIyMSw2 ICsyMzQsMTIgQEAgdXNiYzBfaW50OiB1c2JjMC1pbnQgewo+ICAJCX07Cj4gIAl9Owo+ICAKPiAr CWh5bTg1NjMgewo+ICsJCXJ0Y19pbnRfbDogcnRjLWludC1sIHsKPiArCQkJcm9ja2NoaXAscGlu cyA9IDwwIFJLX1BCMCBSS19GVU5DX0dQSU8gJnBjZmdfcHVsbF91cD47Cj4gKwkJfTsKPiArCX07 Cj4gKwoKcGxlYXNlIHNvcnQgbm9kZXMgYWxwaGFiZXRpY2FsbHkgKGhkbWkgLT4gaHltODU2MykK SSBkaWQgdGhhdCB3aGVuIGFwcGx5aW5nLgoKClRoYW5rcwpIZWlrbwoKCj4gIAloZG1pIHsKPiAg CQloZG1pMF90eF9vbl9oOiBoZG1pMC10eC1vbi1oIHsKPiAgCQkJcm9ja2NoaXAscGlucyA9IDw0 IFJLX1BCNiBSS19GVU5DX0dQSU8gJnBjZmdfcHVsbF9ub25lPjsKPiAKPiBiYXNlLWNvbW1pdDog ODczMjBiZTlmMGQyNGZjZTY3NjMxYjdlZWY5MTlmMGI3OWMzZTQ1Ywo+IAoKCgoKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1h aWxpbmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK