Re: [PATCH] libata: Add Intel SCH PATA Support

[Jeff Garzik <jgarzik@pobox.com>]

Alek Du wrote:
> Hi Sergei and All,
> 
> I modified the driver again according to comments from Sergei, please help to review it.
> 
> 
>>From 9a318d7ff2fc55811374b5b959524f5afcb8d5a6 Mon Sep 17 00:00:00 2001
> From: Alek Du <alek.du@intel.com>
> Date: Mon, 5 May 2008 14:32:04 +0800
> Subject: [PATCH] libata: Add Intel SCH PATA Support
> 
> This patch adds Intel SCH chipsets (AF82US15W, AF82US15L, AF82UL11L) PATA controller
> support.
> 
> Signed-off-by: Alek Du <alek.du@intel.com>
> ---
>  drivers/ata/Kconfig    |    9 ++
>  drivers/ata/Makefile   |    1 +
>  drivers/ata/pata_sch.c |  244 ++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 254 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/ata/pata_sch.c

overall, looks good.

your suspend/resume routines are copies of the in-kernel
ata_pci_device_suspend/resume, and should be removed (just refer 
directly to the generic functions)

agree w/ Alan and Sergei's comments, too

	Jeff