Re: [patch 1/1] pata_atiixp: Don't disable

[Jeff Garzik <jeff@garzik.org>]

akpm@linux-foundation.org wrote:
> From: Alan Cox <alan@lxorguk.ukuu.org.uk>
> 
> A couple of distributions (Fedora, Ubuntu) were having weird problems with the
> ATI IXP series PATA controllers being reported as simplex.  At the heart of
> the problem is that both distros ignored the recommendations to load pata_acpi
> and ata_generic *AFTER* specific host drivers.
> 
> The underlying cause however is that if you D3 and then D0 an ATI IXP it
> helpfully throws away some configuration and won't let you rewrite it.
> 
> Add checks to ata_generic and pata_acpi to pin ATIIXP devices.  Possibly the
> real answer here is to quirk them and pin them, but right now we can't do that
> before they've been pcim_enable()'d by a driver.
> 
> I'm indebted to David Gero for this.  His bug report not only reported the
> problem but identified the cause correctly and he had tested the right values
> to prove what was going on
> 
> [If you backport this for 2.6.24 you will need to pull in the 2.6.25
> removal of the bogus WARN_ON() in pcim_enagle]
> 
> Signed-off-by: Alan Cox <alan@redhat.com>
> Tested-by: David Gero <davidg@havidave.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  drivers/ata/ata_generic.c |    6 ++++++
>  drivers/ata/pata_acpi.c   |    6 ++++++
>  2 files changed, 12 insertions(+)

applied