From: Jeff Garzik <jgarzik@pobox.com>
To: Steffen Klassert <klassert@mathematik.tu-chemnitz.de>
Cc: netdev@vger.kernel.org, Gunnar Larisch <Gunnar.Larisch@gmx.de>
Subject: Re: [PATCH 1/2] 3c980-TX needs EXTRA_PREAMBLE
Date: Tue, 06 May 2008 12:23:01 -0400 [thread overview]
Message-ID: <482085E5.6030900@pobox.com> (raw)
In-Reply-To: <12099888891786-git-send-email-klassert@mathematik.tu-chemnitz.de>
Steffen Klassert wrote:
> From: Gunnar Larisch <Gunnar.Larisch@gmx.de>
>
> The ethernet card 3c980-TX needs a mdio_sync() to initialize the ethernet
> properly. This is forced by adding an EXTRA_PREAMBLE to its drv_flags.
>
> Without this, the driver did not reconnect after a link loss.
>
> Signed-off-by: Gunnar Larisch <Gunnar.Larisch@gmx.de>
> Acked-by: Steffen Klassert <klassert@mathematik.tu-chemnitz.de>
> ---
> drivers/net/3c59x.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/3c59x.c b/drivers/net/3c59x.c
> index 6f8e7d4..e93c378 100644
> --- a/drivers/net/3c59x.c
> +++ b/drivers/net/3c59x.c
> @@ -319,7 +319,7 @@ static struct vortex_chip_info {
> {"3c920B-EMB-WNM (ATI Radeon 9100 IGP)",
> PCI_USES_MASTER, IS_TORNADO|HAS_MII|HAS_HWCKSM, 128, },
> {"3c980 Cyclone",
> - PCI_USES_MASTER, IS_CYCLONE|HAS_HWCKSM, 128, },
> + PCI_USES_MASTER, IS_CYCLONE|HAS_HWCKSM|EXTRA_PREAMBLE, 128, },
>
> {"3c980C Python-T",
applied 1-2
prev parent reply other threads:[~2008-05-06 16:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 12:01 [PATCH 1/2] 3c980-TX needs EXTRA_PREAMBLE Steffen Klassert
2008-05-05 12:01 ` [PATCH 2/2] 3c59x: use netstats in net_device structure Steffen Klassert
2008-05-06 16:23 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482085E5.6030900@pobox.com \
--to=jgarzik@pobox.com \
--cc=Gunnar.Larisch@gmx.de \
--cc=klassert@mathematik.tu-chemnitz.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.