From mboxrd@z Thu Jan  1 00:00:00 1970
From: Neil Turton <nturton@solarflare.com>
Subject: Re: [PATCH] msix: revoke correct amount of msi-x related
	iomem
Date: Tue, 06 May 2008 17:31:49 +0100
Message-ID: <482087F5.1030903@solarflare.com>
References: <18459.22471.351306.107348@gargle.gargle.HOWL>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <18459.22471.351306.107348@gargle.gargle.HOWL>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Espen Skoglund <espen.skoglund@netronome.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Espen Skoglund wrote:
> +                        self.msix_entries = (message_cont_lo + \
> +                                             message_cont_hi << 8) \
> +                                             & MSIX_SIZE_MASK

That still doesn't look right to me since "+" binds tighter than "<<".
I think it needs some more parentheses around "message_cont_hi << 8", at
least if I've understood what the code's supposed to do.

Cheers, Neil.