From: Wang Chen <wangchen@cn.fujitsu.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] NET: Remove PACKET_FASTROUTE
Date: Wed, 07 May 2008 17:45:50 +0800 [thread overview]
Message-ID: <48217A4E.7060200@cn.fujitsu.com> (raw)
In-Reply-To: <20080507.023524.193709565.davem@davemloft.net>
David Miller said the following on 2008-5-7 17:35:
> From: Wang Chen <wangchen@cn.fujitsu.com>
> Date: Wed, 07 May 2008 17:07:10 +0800
>
>> Since we do not support fastroute anymore, remove macro PACKET_FASTROUTE.
>>
>> Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
>
> We should leave it there so that this value is not accidently
> allocatod to another purpose.
>
> If you really really want to remove it, at least add a comment
> there that value "6" used to be allocated to PACKET_FASTROUTE,
> and therefore cannot be reused.
>
> But, to be honest, keeping the define there serves that purpose just
> as well.
>
Yes. I agree. So leave it there.
prev parent reply other threads:[~2008-05-07 9:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 9:07 [PATCH] NET: Remove PACKET_FASTROUTE Wang Chen
2008-05-07 9:35 ` David Miller
2008-05-07 9:45 ` Wang Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48217A4E.7060200@cn.fujitsu.com \
--to=wangchen@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.