Re: [HIFN 03/n]: Indicate asynchronous processing to crypto API

[Patrick McHardy <kaber@trash.net>]

Evgeniy Polyakov wrote:
> Hi.
>
> On Wed, May 07, 2008 at 02:19:36PM +0200, Patrick McHardy (kaber@trash.net) wrote:
>   
>>     hifn_setup_crypto() needs to return -EINPROGRESS on success to indicate
>>     asynchronous processing to the crypto API. This also means it must not
>>     return the errno code returned by hifn_process_queue(), if any.
>>     
>
> Then how to indicate that error occured?
> What if we will return -EINPROGRESS in case of success and negative
> errno otherwise?
>   

The completion handler should be called with the error code,
a later patch of mine will change that. Returning it while
enqueing a new request is wrong since the error affects a
different request. Queue processing should happen on completion
of requests anyway to make sure the queue is kept running
while requests are queued (and avoid reordering).

>   
>> @@ -2202,9 +2202,9 @@ static int hifn_setup_crypto(struct ablkcipher_request *req, u8 op,
>>  		return err;
>>  
>>  	if (dev->started < HIFN_QUEUE_LENGTH &&	dev->queue.qlen)
>> -		err = hifn_process_queue(dev);
>> +		hifn_process_queue(dev);
>>  
>> -	return err;
>> +	return -EINPROGRESS;
>>     
>
> Thus we are not able to return any error at all...
>   

We are, errors affecting *this request* are returned as they should be.