From: Andi Kleen <andi@firstfloor.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Mirco Tischler <mt-ml@gmx.de>, Ingo Molnar <mingo@redhat.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [BUG]:WARNING: at arch/x86/kernel/rtc.c:122 in 2.6.26-rc1
Date: Thu, 08 May 2008 12:52:30 +0200 [thread overview]
Message-ID: <4822DB6E.9040504@firstfloor.org> (raw)
In-Reply-To: <alpine.LFD.1.10.0805081207050.3318@apollo.tec.linutronix.de>
Thomas Gleixner wrote:
> On Thu, 8 May 2008, Andi Kleen wrote:
>>> May 7 21:52:04 kernel: [4294896.091827] Extended CMOS year: 2000
>>> May 7 21:52:04 kernel: [4294896.091827] x86 PAT enabled: cpu 0, old 0x7040600070406, new 0x7010600070106
>>> May 7 21:52:04 kernel: [4294896.091827] Back to C!
>>> May 7 21:52:04 kernel: [4294896.091827] Extended CMOS year: 2000
>> If the data is read correctly (and it looks like it) then just the bit
>> is wrong and we should ignore it I guess. So just remove the
>> WARN_ON_ONCE()?
>
> You put a printk there in the first place :) I changed it to
> WARN_ON_ONCE as one line printks are more likely to be ignored.
Ignoring would have been fine here, but point taken.
> I'm all for it to remove the while BCD check, which is hardcoded to
> ALWAYS_BCD = 1 since linux 1.0.
Fine for me.
-Andi
prev parent reply other threads:[~2008-05-08 10:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 18:05 [BUG]:WARNING: at arch/x86/kernel/rtc.c:122 in 2.6.26-rc1 Mirco Tischler
2008-05-07 18:11 ` Mirco Tischler
2008-05-07 19:06 ` Thomas Gleixner
2008-05-07 19:32 ` Mirco Tischler
2008-05-07 20:58 ` Thomas Gleixner
2008-05-07 21:46 ` Mirco Tischler
2008-05-07 22:03 ` Andi Kleen
2008-05-08 10:12 ` Thomas Gleixner
2008-05-08 10:52 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4822DB6E.9040504@firstfloor.org \
--to=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mt-ml@gmx.de \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.