All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: kvm-devel@lists.sourceforge.net, Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH] Fix e1000 can_receive handler
Date: Thu, 08 May 2008 20:21:04 +0300	[thread overview]
Message-ID: <48233680.50401@qumranet.com> (raw)
In-Reply-To: <4823323A.8040809@qumranet.com>

Avi Kivity wrote:
>
> Note that flow control still makes sense since it allows us to buffer 
> some packets if the guest is scheduled out.  But we can't use it as 
> the primary mechanism since it won't exist with multiqueue NICs (where 
> the virtio descriptors are fed to driver).
>

... are fed to the hardware, I meant.

And to clarify further, I do think the patch is correct, but that virtio 
should be able to work well without it under ordinary circumstances.


-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone

  reply	other threads:[~2008-05-08 17:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-07 21:40 [PATCH] Fix e1000 can_receive handler Anthony Liguori
2008-05-08 13:26 ` Aurelien Jarno
2008-05-08 14:03   ` Anthony Liguori
2008-05-08 17:02     ` Avi Kivity
2008-05-08 17:21       ` Avi Kivity [this message]
2008-05-08 18:41       ` Anthony Liguori
2008-05-09  7:47         ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48233680.50401@qumranet.com \
    --to=avi@qumranet.com \
    --cc=aliguori@us.ibm.com \
    --cc=aurelien@aurel32.net \
    --cc=kvm-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.