From: Clemens Ladisch <clemens@ladisch.de>
To: maximilian attems <max@stro.at>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, uwe_debbug@arcor.de
Subject: Re: [PATCH] emux midi synthesizer doesn't honor SOFT_PEDAL-release event
Date: Fri, 09 May 2008 09:33:56 +0200 [thread overview]
Message-ID: <4823FE64.3050603@ladisch.de> (raw)
In-Reply-To: <1210280016-14742-1-git-send-email-max@stro.at>
maximilian attems wrote:
> The attached patch fixes this problem by analysing the value (0 or 127)
> of the midi control event and resetting the effect register in case of a
> release event.
> ...
> + if (chan->control[type])
Boolean MIDI controls should interpret 0..63 as false and 64..127 as
true, i.e.:
+ if (chan->control[type] >= 64)
Regards,
Clemens
next prev parent reply other threads:[~2008-05-09 7:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-08 20:53 [PATCH] emux midi synthesizer doesn't honor SOFT_PEDAL-release event maximilian attems
2008-05-09 7:33 ` Clemens Ladisch [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-05-09 8:44 maximilian attems
2008-05-09 10:48 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4823FE64.3050603@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=max@stro.at \
--cc=tiwai@suse.de \
--cc=uwe_debbug@arcor.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.