From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JvaUM-000303-DD for mharc-grub-devel@gnu.org; Mon, 12 May 2008 12:02:58 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JvaUJ-0002z4-1r for grub-devel@gnu.org; Mon, 12 May 2008 12:02:55 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JvaUH-0002yU-AH for grub-devel@gnu.org; Mon, 12 May 2008 12:02:53 -0400 Received: from [199.232.76.173] (port=43301 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JvaUH-0002yO-4C for grub-devel@gnu.org; Mon, 12 May 2008 12:02:53 -0400 Received: from fk-out-0910.google.com ([209.85.128.189]:3120) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JvaUG-0003ta-3i for grub-devel@gnu.org; Mon, 12 May 2008 12:02:52 -0400 Received: by fk-out-0910.google.com with SMTP id 18so1955121fkq.10 for ; Mon, 12 May 2008 09:02:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:user-agent:mime-version:to:subject:references:in-reply-to:content-type; bh=WlfDx77iY/zxkmn/Z/5rkxGUGShapE61fEGhJkfvGKY=; b=tLs+qAkdd8PjBd8Du4FLYPu05LJGM2ZhkqppdHvhnC/NH3TVqdyt+OYuf5bJLW5i+e2NyXueWye2jBjqAFU9XIgQSmhNSKri7BeG3Nl64H16tm+U8YEsjPX/SeJHFoZaptlTIo4LeIgwJdJLF+adH2O6ZNM90W2ecEvdkRHqX+8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references:in-reply-to:content-type; b=pYEwo9XcJZoAdzDicSnPPO+G2c04qoTzfJLeLpvLPOat9OjH8l9C1zUjlieG5d4u18moihFdR+kLRd/qAOIf9+jAn/LVWBNcqPx162uO7UOk/bQpOdDtETGVYvImgJ38V9Ceh+6lgbTOO9NCpcsUF06U6l9Skrr2Hld5Fzmxrtc= Received: by 10.86.59.18 with SMTP id h18mr14502759fga.67.1210608169822; Mon, 12 May 2008 09:02:49 -0700 (PDT) Received: from ?192.168.0.2? ( [79.114.58.223]) by mx.google.com with ESMTPS id 12sm6852282fgg.0.2008.05.12.09.02.47 (version=SSLv3 cipher=RC4-MD5); Mon, 12 May 2008 09:02:48 -0700 (PDT) Message-ID: <48286A26.2090202@gmail.com> Date: Mon, 12 May 2008 19:02:46 +0300 From: =?ISO-8859-1?Q?T=F6r=F6k_Edwin?= User-Agent: Mozilla-Thunderbird 2.0.0.12 (X11/20080420) MIME-Version: 1.0 To: The development of GRUB 2 References: <481590B8.7000405@gmail.com> <20080429134626.GB8328@thorin> <481DC1BC.6020002@gmail.com> <20080506133126.GG5055@thorin> <4826DA0D.9070302@gmail.com> <20080512154409.GD1841@thorin> In-Reply-To: <20080512154409.GD1841@thorin> Content-Type: multipart/mixed; boundary="------------050901060608040407040508" X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) Subject: Re: Bug#478238: grub-probe: fails to find drive for /dev/sda10 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 May 2008 16:02:56 -0000 This is a multi-part message in MIME format. --------------050901060608040407040508 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Robert Millan wrote: > On Sun, May 11, 2008 at 02:35:41PM +0300, T=F6r=F6k Edwin wrote: > =20 >> /dev/sda9 is not a valid OpenBSD partition, and in partmap/pc.c:176 th= e >> iteration fails with an error: invalid disk label magic 0x%x. >> If I replace that return with a continue, it works. >> >> The problem is that grub2 stops looking for more partitions as soon as= >> it encountered the invalid partition, >> =20 > > I think a correct fix for this belongs in grub_partition_iterate(). It= should > only let its hook determine abortability rather than mandate that inval= id > partitions should cause abortion. Please, can you test the attached pa= tch? > =20 I tested the patch, however it still says: grub-probe: error: Cannot find a GRUB drive for /dev/sda10. Check your device.map. I notice that /dev/sda10 appears in the -vv output though: home/egrub-probe: info: opening the device `/dev/sda9' grub-probe: info: opening the device `/dev/sda9' grub-probe: info: /dev/sda10 starts from 83987883 grub-probe: info: opening the device hd0 I attached the full output of grub-probe -d /dev/sda10 -vv, for the case when /dev/sda9 has the wrong partition type. Best regards, --Edwin --------------050901060608040407040508 Content-Type: application/x-bzip; name="log.bz2" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="log.bz2" QlpoOTFBWSZTWevYr4gAYsrfgEAQQM//+DykmwD/79/wYA7YAefKnd7DeAoDwgoBQBQpVsap L3dzFoJAgSUknoZk9VNn6pQAPUAAAaAENSaTT1N+qhp6hp6g0AAAAAEmkiSap+knkjTygyAD IMTNE00GA0AAA0AAAAAATVKmIJqeiTMU0NHpNMmh6QaGgaBSkkAJoJkmqPxNCano0eqPUeao PUPk1zso2T9f2pDxY+fboPBTLLt4cioqqiImJw8a4zHIcAqKQ5sANu2jCoBxhDeTkhStigiL FBEWKCIsURixQRFiiiixQRIaSzLFCmClhSmimbYoU0alMqpLMmQLM0qSmpqQoZiQsTcakgVh CCsgmSJuR2uqMCWE2Q/eAhqSZCBxCK5hmXqprWlchzYiHO/Nhe+ypb9B4teTu7sw7+rlzuzn FiikUhJMYFQUeu1iIMUXGGdpIH1eH9+wAA9LCu+FboRuBfGGDFJkVgTQV3UVpTSLQq1owl25 GZSblWBtmi98pxakMrBWGRWMzMzHMvhgH+2AdVMqocCS41Bc9G5kV8Va0S29sXs286uy8dkg 481O5NrVm2Z8pTUpXuovCirzYB2RW9FsiXjgGdZbiG7BMWOTVFvoqv56dvh2/DyceX79+vLj 5ctrKWV6dASEYoSKkhAHYJBr57cZSndceh433SwN4mpOQHIgTkEI8cu3qFzd7E1tiuAbSZMk aQSCPSylpJZJBCELkCSZq8pCxEkkk0peQajExxMBmZmelROWi2o0lK7J1oroMYxjGWajAwL7 4RCUJQghBAEIIQQgYNjYxpMTSYDAYrqFKUoxjGMcxjYxjTTVkiJKy2cRGbTEQQQoNi622yd0 ZzQSmdOk6S60XRqOsRGzJaUqipbvRk1Ovg16a78/yUbCJ8sUsxEnv52TtatMsWWTVotUaWtM 7y1L5xecYh3q3hvp5w2W9VyVckuIcKtKeUuctIymFyjanKhxWo4hi3hLplSp25wzIZkMyGZD frUMxMwZgzBmJSmxdFSvX8z8bMpmTMTE8jCYmZg1ZTRGlhCSxjEkklgJBRQV3SAJqi3DKKzC RrjCU+CO6j8yg+Kpc1MiDfw1v5KPtR6sFHP35UqZJvRKZryyEpkJTUQtYyGBLWVU4FBxU/7l J3+B6Zj+YYwmPKWqjWM2R8O+q88qyU158rbMGMqNFxVHDKhYlkjMzNiqNxbs+9di14e0KLWb tguKCXZkra598Vpbug15USt+FSb+Ct3DZU6AeilWuumuIKrhiGhPSMs3Ytq9VliaF4ykWscE XK9avTWTeixm1ry1ivrKeqTe4eeyPHIG5058qQc1ulssq1577dKd9NtrpIaKDlVy6t/OmM71 e0uqWgj5pIeeRmSo/xUayJJ2vCFr3Sm3VnlnhC8OPeK+4POU3bBcNKPdyUfGrkldZPJz2K84 V2ZKUzIR0GdQXMTjVaSeq8A9Y8lPHwZy4ue6xkyyxiZGZkjpVM1uclNt7xoZHBTI1LN+wg3y syT3rbeHLhA4yuFM31L3KtqG3lu39s9U85TXfWhK88I4hKcEct4XDfRvtupOOEq3LZR4I6rK ZG0uCjnGPNz7bjeztRxlHTd02UeQXANlHFv5UO8cuRbSWKZv4pzk81VR3yE2I57s3+Tpx6a1 KrbboPLFao42acOUuYuovI7Z4UOMV7qeEp0k6hwdtbu227cumLlJ41eK5rx5cunTxJeMHsk3 +J5YLxQRrFQ67Z2YYymR25rrlN9W5ty7UNwuXH1leGdPdPJ552474HKOtDrGStqO+Sc6do4r mHDdy7qXkRvhKcN3TS+aSHXCJ2x3Dx4F351ajxqxTysjUbcfyL9dqpoecb3djKmMYxjGMYxm K7RBpTLSjt0605SwspgyMrFqo3AtI0qs3aI2aWyI40S11isKDjbSnuRKeqj+FPt5FX7qf2pp H3l/up9C/uNyk/fIg+w/amlOv1L9S/VHt+1j0tWrVxIh+H5qyHxDS/EsrSWK+EZ/mjdGpuDE /NevIboNlWRPaFzUqvUVegoPqo/XWf0U/rJ5qfx/KjjIT7KPVexQc4omE9kdo/RV/NUTtxJG ZU0t2E8VdquUV7oR30cXn8MzGMmUxL+VHcoOUvrL7lL3ii68ki2nui6nIuSJfOyDqkDtOhFE REREREREYiKLGMssZYfLemGZuUffUeij1RsLkp+6UXkHSn2lJvvaPhKTKCxziDCha2Koe7JI 4ZmMssPMpVdZJdVEvhpp8kWqLrR6U965R9FHH5IlP2q7KvYPxUjfPvUqv2kunqqNR7GTi7lS LwX0Vd73N3AoNFK/hIX3b1PrHSKp5R+Up7B9I/oh4B6hr+seseE+CPpXMs7EvAq0LeXdVavD ApmKPWiMF/dVpiW6lwUGmUbqkX0wpMh6Fso3rfLXHV+mcy+LOEeEc5tDSKgSgaIzM5kaok4S UThVY1i0wtUKdj+HXSBHx2BJ32w3lOiTsfH4X708mrh9lhmWhQZkE7pXzQvGiLvUT8tigcMk L6qP7UF8FP8ce2tbSaCU/DrKV8392GMZOKaxmZZFpgoyUYUSUZKJKMlElGSqwoyUSUZKJKMl EiUSglLVlEolEolEo0aoUSUYFEoySjNMVphqwWmGrKXG0piwpMVC1RaAOeIq0qRe/ei9mKhe EK4YKHlT8BdSg/Qp7pOxQelU3k4Rso/9j7sjuorrlI4IkvkUGUi45YMR4iqdIQ4YqUzITSNk fRRtCi4AeimFJ61NYo5R4yRxhHRF/tP+qaUvGUi6kF0ykW+iXAW3iFz0itKfLyK8isKo7l7X p0kJqGoYVQ0uBQfuB6FJ7ynIp9lSvmt1TpnNT4+9IXJUrxJ4/Yt3UFHriRmVQdQKtlPWU+BO spO1U85TclU5ZRqhHQoN3ZfEEc0eyjfwSlx18o0QmRknPI0RJakqsgRwZcinFEtsKptFeWUi /BJDjkUtOkKaYhvRf+LuSKcKEh17FfEA --------------050901060608040407040508--