From: Timur Tabi <timur@freescale.com>
To: paulus@samba.org
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Add null pointer check to of_find_property
Date: Mon, 12 May 2008 11:46:46 -0500 [thread overview]
Message-ID: <48287476.1050005@freescale.com> (raw)
In-Reply-To: <1210187999-20274-1-git-send-email-timur@freescale.com>
Timur Tabi wrote:
> Update function of_find_property() to return NULL if the device_node passed
> to it is also NULL. Otherwise, passing NULL will cause a null pointer
> dereference.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
Paul, please pick this up for 2.6.26. The legacy_serial driver will crash
without it if there's no 'chosen' node in the device tree. I'm sure there are
other drivers that would crash similarly if given a device tree with missing nodes.
--
Timur Tabi
Linux kernel developer at Freescale
prev parent reply other threads:[~2008-05-12 16:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 19:19 [PATCH] Add null pointer check to of_find_property Timur Tabi
2008-05-07 19:27 ` Grant Likely
2008-05-07 23:21 ` Michael Ellerman
2008-05-09 4:50 ` Paul Mackerras
2008-05-12 16:46 ` Timur Tabi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48287476.1050005@freescale.com \
--to=timur@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.