All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jochen Friedrich <jochen@scram.de>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Wim Van Sebroeck <wim@iguana.be>,
	Timur Tabi <timur@freescale.com>
Subject: Re: [PATCH 1/3] [WATCHDOG] mpc83xx_wdt: add support for MPC86xx CPUs
Date: Mon, 12 May 2008 21:44:51 +0200	[thread overview]
Message-ID: <48289E33.3030100@scram.de> (raw)
In-Reply-To: <64629276-8337-4FFE-B3E1-306678BF179D@kernel.crashing.org>

Hi Kumar,

>> Also move the probe code into subsys_initcall, because we want start
>> pinging the watchdog ASAP, and misc devices are available in
>> subsys_initcall.
>>
>> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
>> ---
>> drivers/watchdog/Kconfig       |    4 +-
>> drivers/watchdog/mpc83xx_wdt.c |   63 +++++++++++++++++++++++++++++++ 
>> +++++----
> 
> we should rename it to mpc8xxx_wdt.c

IIRC, even MPC8xx also has the same style of wdt device, just with a different
prescale factor.

Thanks,
Jochen

  reply	other threads:[~2008-05-12 19:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-12 18:52 [PATCH 1/3] [WATCHDOG] mpc83xx_wdt: add support for MPC86xx CPUs Anton Vorontsov
2008-05-12 18:58 ` Scott Wood
2008-05-12 19:24 ` Kumar Gala
2008-05-12 19:44   ` Jochen Friedrich [this message]
2008-05-12 20:53   ` Anton Vorontsov
2008-05-12 20:59     ` Scott Wood
2008-05-12 21:01       ` Timur Tabi
2008-05-12 21:18         ` Anton Vorontsov
2008-05-12 21:20           ` Timur Tabi
2008-05-12 21:35             ` Anton Vorontsov
2008-05-12 21:42               ` Timur Tabi
2008-05-12 21:48                 ` Anton Vorontsov
2008-05-12 21:55                   ` Timur Tabi
2008-05-12 22:12                     ` Anton Vorontsov
2008-05-13  1:06                       ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48289E33.3030100@scram.de \
    --to=jochen@scram.de \
    --cc=galak@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=timur@freescale.com \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.